mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
28e9a022df
Currently there are many instances where assert.fail is directly passed to a callback for error handling. Unfortunately this will swallow the error as it is the third argument of assert.fail that sets the message not the first. This commit adds a new function to test/common.js that simply wraps assert.fail and calls it with the provided message. Tip of the hat to @trott for pointing me in the direction of this. PR-URL: https://github.com/nodejs/node/pull/3453 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
44 lines
985 B
JavaScript
44 lines
985 B
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var fs = require('fs');
|
|
|
|
var stream = fs.createReadStream(__filename, {
|
|
bufferSize: 64
|
|
});
|
|
var err = new Error('BAM');
|
|
|
|
stream.on('error', common.mustCall(function errorHandler(err_) {
|
|
console.error('error event');
|
|
process.nextTick(function() {
|
|
assert.equal(stream.fd, null);
|
|
assert.equal(err_, err);
|
|
});
|
|
}));
|
|
|
|
fs.close = common.mustCall(function(fd_, cb) {
|
|
assert.equal(fd_, stream.fd);
|
|
process.nextTick(cb);
|
|
});
|
|
|
|
var read = fs.read;
|
|
fs.read = function() {
|
|
// first time is ok.
|
|
read.apply(fs, arguments);
|
|
// then it breaks
|
|
fs.read = function() {
|
|
var cb = arguments[arguments.length - 1];
|
|
process.nextTick(function() {
|
|
cb(err);
|
|
});
|
|
// and should not be called again!
|
|
fs.read = function() {
|
|
throw new Error('BOOM!');
|
|
};
|
|
};
|
|
};
|
|
|
|
stream.on('data', function(buf) {
|
|
stream.on('data', common.fail); // no more 'data' events should follow
|
|
});
|