mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
695590e386
Currently there are two compiler warnings generated from the addons test
callback-scope:
../binding.cc:44:10:
warning: 'Resolve' is deprecated [-Wdeprecated-declarations]
local->Resolve(v8::Undefined(isolate));
^
../../../../deps/v8/include/v8.h:3893:45:
note: 'Resolve' has been explicitly marked deprecated here
V8_DEPRECATED("Use maybe version", void Resolve(Local<Value> value));
^
../binding.cc:52:54:
warning: 'New' is deprecated [-Wdeprecated-declarations]
persistent.Reset(isolate, v8::Promise::Resolver::New(isolate));
^
../../../../deps/v8/include/v8.h:3880:42:
note: 'New' has been explicitly marked deprecated here
Local<Resolver> New(Isolate* isolate));
This commit updates the test to use non-deprecated functions.
PR-URL: https://github.com/nodejs/node/pull/19252
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|
||
|---|---|---|
| .. | ||
| async-hello-world | ||
| async-hooks-id | ||
| async-hooks-promise | ||
| async-resource | ||
| at-exit | ||
| buffer-free-callback | ||
| callback-scope | ||
| dlopen-ping-pong | ||
| errno-exception | ||
| heap-profiler | ||
| hello-world | ||
| hello-world-esm | ||
| hello-world-function-export | ||
| load-long-path | ||
| make-callback | ||
| make-callback-domain-warning | ||
| make-callback-recurse | ||
| new-target | ||
| node-module-version | ||
| not-a-binding | ||
| null-buffer-neuter | ||
| openssl-binding | ||
| openssl-client-cert-engine | ||
| parse-encoding | ||
| repl-domain-abort | ||
| stringbytes-external-exceed-max | ||
| symlinked-module | ||
| zlib-binding | ||
| .gitignore | ||
| testcfg.py | ||