mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
92146e00fd
This patch adds (port > 0xffff) check after each digit in the loop and prevents integer overflow. PR-URL: https://github.com/nodejs/node/pull/15794 Refs: https://github.com/w3c/web-platform-tests/pull/7602 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
64 lines
2.0 KiB
JavaScript
64 lines
2.0 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasIntl) {
|
|
// A handful of the tests fail when ICU is not included.
|
|
common.skip('missing Intl');
|
|
}
|
|
|
|
const URL = require('url').URL;
|
|
const assert = require('assert');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
// Tests below are not from WPT.
|
|
const tests = require(fixtures.path('url-tests'));
|
|
const failureTests = tests.filter((test) => test.failure).concat([
|
|
{ input: '' },
|
|
{ input: 'test' },
|
|
{ input: undefined },
|
|
{ input: 0 },
|
|
{ input: true },
|
|
{ input: false },
|
|
{ input: null },
|
|
{ input: new Date() },
|
|
{ input: new RegExp() },
|
|
{ input: () => {} }
|
|
]);
|
|
|
|
const expectedError = common.expectsError(
|
|
{ code: 'ERR_INVALID_URL', type: TypeError }, failureTests.length);
|
|
|
|
for (const test of failureTests) {
|
|
assert.throws(
|
|
() => new URL(test.input, test.base),
|
|
(error) => {
|
|
if (!expectedError(error))
|
|
return false;
|
|
|
|
// The input could be processed, so we don't do strict matching here
|
|
const match = (`${error}`).match(/Invalid URL: (.*)$/);
|
|
if (!match) {
|
|
return false;
|
|
}
|
|
return error.input === match[1];
|
|
});
|
|
}
|
|
|
|
const additional_tests =
|
|
require(fixtures.path('url-tests-additional.js'));
|
|
|
|
for (const test of additional_tests) {
|
|
const url = new URL(test.url);
|
|
if (test.href) assert.strictEqual(url.href, test.href);
|
|
if (test.origin) assert.strictEqual(url.origin, test.origin);
|
|
if (test.protocol) assert.strictEqual(url.protocol, test.protocol);
|
|
if (test.username) assert.strictEqual(url.username, test.username);
|
|
if (test.password) assert.strictEqual(url.password, test.password);
|
|
if (test.hostname) assert.strictEqual(url.hostname, test.hostname);
|
|
if (test.host) assert.strictEqual(url.host, test.host);
|
|
if (test.port !== undefined) assert.strictEqual(url.port, test.port);
|
|
if (test.pathname) assert.strictEqual(url.pathname, test.pathname);
|
|
if (test.search) assert.strictEqual(url.search, test.search);
|
|
if (test.hash) assert.strictEqual(url.hash, test.hash);
|
|
}
|