mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
7535a94c8a
Adds a new `../common/fixtures' module to begin normalizing `test/fixtures` use. Our test code is a bit inconsistent with regards to use of the fixtures directory. Some code uses `path.join()`, some code uses string concats, some other code uses template strings, etc. In mnay cases, significant duplication of code is seen when accessing fixture files, etc. This updates many (but by no means all) of the tests in the test suite to use the new consistent API. There are still many more to update, which would make an excelent Code-n-Learn exercise. PR-URL: https://github.com/nodejs/node/pull/14332 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
51 lines
1.3 KiB
JavaScript
51 lines
1.3 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
// Adding a CA certificate to contextWithCert should not also add it to
|
|
// contextWithoutCert. This is tested by trying to connect to a server that
|
|
// depends on that CA using contextWithoutCert.
|
|
|
|
const {
|
|
assert, connect, keys, tls
|
|
} = require(fixtures.path('tls-connect'));
|
|
|
|
const contextWithoutCert = tls.createSecureContext({});
|
|
const contextWithCert = tls.createSecureContext({});
|
|
contextWithCert.context.addCACert(keys.agent1.ca);
|
|
|
|
const serverOptions = {
|
|
key: keys.agent1.key,
|
|
cert: keys.agent1.cert,
|
|
};
|
|
|
|
const clientOptions = {
|
|
ca: [keys.agent1.ca],
|
|
servername: 'agent1',
|
|
rejectUnauthorized: true,
|
|
};
|
|
|
|
// This client should fail to connect because it doesn't trust the CA
|
|
// certificate.
|
|
clientOptions.secureContext = contextWithoutCert;
|
|
|
|
connect({
|
|
client: clientOptions,
|
|
server: serverOptions,
|
|
}, function(err, pair, cleanup) {
|
|
assert(err);
|
|
assert.strictEqual(err.message, 'unable to verify the first certificate');
|
|
cleanup();
|
|
|
|
// This time it should connect because contextWithCert includes the needed CA
|
|
// certificate.
|
|
clientOptions.secureContext = contextWithCert;
|
|
connect({
|
|
client: clientOptions,
|
|
server: serverOptions,
|
|
}, function(err, pair, cleanup) {
|
|
assert.ifError(err);
|
|
cleanup();
|
|
});
|
|
});
|