mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
588ee2296a
In vm, the setter interceptor should not copy a value onto the sandbox, if setting it on the global object will fail. It will fail if we are in strict mode and set a value without declaring it. Fixes: https://github.com/nodejs/node/issues/5344 PR-URL: https://github.com/nodejs/node/pull/7908 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
28 lines
837 B
JavaScript
28 lines
837 B
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const vm = require('vm');
|
|
const ctx = vm.createContext();
|
|
|
|
// Test strict mode inside a vm script, i.e., using an undefined variable
|
|
// throws a ReferenceError. Also check that variables
|
|
// that are not successfully set in the vm, must not be set
|
|
// on the sandboxed context.
|
|
|
|
vm.runInContext('w = 1;', ctx);
|
|
assert.strictEqual(1, ctx.w);
|
|
|
|
assert.throws(function() { vm.runInContext('"use strict"; x = 1;', ctx); },
|
|
/ReferenceError: x is not defined/);
|
|
assert.strictEqual(undefined, ctx.x);
|
|
|
|
vm.runInContext('"use strict"; var y = 1;', ctx);
|
|
assert.strictEqual(1, ctx.y);
|
|
|
|
vm.runInContext('"use strict"; this.z = 1;', ctx);
|
|
assert.strictEqual(1, ctx.z);
|
|
|
|
// w has been defined
|
|
vm.runInContext('"use strict"; w = 2;', ctx);
|
|
assert.strictEqual(2, ctx.w);
|