mirror of
https://github.com/nodejs/node.git
synced 2024-11-30 23:43:09 +01:00
318c982f3b
Makefile assumes that it can pass a list of files to the import checker, whereas the import checker expects a single argument that is interpreted as a blob. Fix that mismatch by accepting multiple arguments in the import checker. Refs: https://github.com/nodejs/node/pull/34565 PR-URL: https://github.com/nodejs/node/pull/34582 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
51 lines
1.5 KiB
Python
Executable File
51 lines
1.5 KiB
Python
Executable File
#!/usr/bin/env python
|
|
|
|
from __future__ import print_function
|
|
import glob
|
|
import io
|
|
import re
|
|
import sys
|
|
import itertools
|
|
|
|
def do_exist(file_name, lines, imported):
|
|
if not any(not re.match('using \w+::{0};'.format(imported), line) and
|
|
re.search('\\b{0}\\b'.format(imported), line) for line in lines):
|
|
print('File "{0}" does not use "{1}"'.format(file_name, imported))
|
|
return False
|
|
return True
|
|
|
|
|
|
def is_valid(file_name):
|
|
with io.open(file_name, encoding='utf-8') as source_file:
|
|
lines = [line.strip() for line in source_file]
|
|
|
|
usings, importeds, line_numbers, valid = [], [], [], True
|
|
for idx, line in enumerate(lines, 1):
|
|
matches = re.search(r'^using (\w+::(\w+));$', line)
|
|
if matches:
|
|
line_numbers.append(idx)
|
|
usings.append(matches.group(1))
|
|
importeds.append(matches.group(2))
|
|
|
|
valid = all([do_exist(file_name, lines, imported) for imported in importeds])
|
|
|
|
sorted_usings = sorted(usings, key=lambda x: x.lower())
|
|
if sorted_usings != usings:
|
|
print("using statements aren't sorted in '{0}'.".format(file_name))
|
|
for num, actual, expected in zip(line_numbers, usings, sorted_usings):
|
|
if actual != expected:
|
|
print('\tLine {0}: Actual: {1}, Expected: {2}'
|
|
.format(num, actual, expected))
|
|
return False
|
|
else:
|
|
return valid
|
|
|
|
if __name__ == '__main__':
|
|
if len(sys.argv) > 1:
|
|
files = []
|
|
for pattern in sys.argv[1:]:
|
|
files = itertools.chain(files, glob.iglob(pattern))
|
|
else:
|
|
files = glob.iglob('src/*.cc')
|
|
sys.exit(0 if all(list(map(is_valid, files))) else 1)
|