mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
2e1b41a708
Prior to this patch `session` event was emitted after `secure` event on TLSSocket, but before `secureConnect` event. This is problematic for `https.Agent` because it must cache session only after verifying the remote peer's certificate. Connecting to a server that presents an invalid certificate resulted in the session being cached after the handshake with the server and evicted right after a certifiate validation error and socket's destruction. A request initiated during this narrow window would pick the faulty session, send it to the malicious server and skip the verification of the server's certificate. Fixes: https://hackerone.com/reports/811502 CVE-ID: CVE-2020-8172 PR-URL: https://github.com/nodejs-private/node-private/pull/200 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> |
||
|---|---|---|
| .. | ||
| dns | ||
| fs | ||
| internal | ||
| _http_agent.js | ||
| _http_client.js | ||
| _http_common.js | ||
| _http_incoming.js | ||
| _http_outgoing.js | ||
| _http_server.js | ||
| _stream_duplex.js | ||
| _stream_passthrough.js | ||
| _stream_readable.js | ||
| _stream_transform.js | ||
| _stream_wrap.js | ||
| _stream_writable.js | ||
| _tls_common.js | ||
| _tls_wrap.js | ||
| .eslintrc.yaml | ||
| assert.js | ||
| async_hooks.js | ||
| buffer.js | ||
| child_process.js | ||
| cluster.js | ||
| console.js | ||
| constants.js | ||
| crypto.js | ||
| dgram.js | ||
| dns.js | ||
| domain.js | ||
| events.js | ||
| fs.js | ||
| http2.js | ||
| http.js | ||
| https.js | ||
| inspector.js | ||
| module.js | ||
| net.js | ||
| os.js | ||
| path.js | ||
| perf_hooks.js | ||
| process.js | ||
| punycode.js | ||
| querystring.js | ||
| readline.js | ||
| repl.js | ||
| stream.js | ||
| string_decoder.js | ||
| sys.js | ||
| timers.js | ||
| tls.js | ||
| trace_events.js | ||
| tty.js | ||
| url.js | ||
| util.js | ||
| v8.js | ||
| vm.js | ||
| wasi.js | ||
| worker_threads.js | ||
| zlib.js | ||