mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
46 lines
1.6 KiB
JavaScript
46 lines
1.6 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
const common = require('../common');
|
|
common.skipIfInspectorDisabled();
|
|
const { strictEqual } = require('assert');
|
|
const { NodeInstance } = require('../common/inspector-helper.js');
|
|
|
|
async function testNoServerNoCrash() {
|
|
console.log('Test there\'s no crash stopping server that was not started');
|
|
const instance = new NodeInstance([],
|
|
`process._debugEnd();
|
|
process.exit(42);`);
|
|
strictEqual(42, (await instance.expectShutdown()).exitCode);
|
|
}
|
|
|
|
async function testNoSessionNoCrash() {
|
|
console.log('Test there\'s no crash stopping server without connecting');
|
|
const instance = new NodeInstance('--inspect=0',
|
|
'process._debugEnd();process.exit(42);');
|
|
strictEqual(42, (await instance.expectShutdown()).exitCode);
|
|
}
|
|
|
|
async function testSessionNoCrash() {
|
|
console.log('Test there\'s no crash stopping server after connecting');
|
|
const script = `process._debugEnd();
|
|
process._debugProcess(process.pid);
|
|
setTimeout(() => {
|
|
console.log("Done");
|
|
process.exit(42);
|
|
});`;
|
|
|
|
const instance = new NodeInstance('--inspect-brk=0', script);
|
|
const session = await instance.connectInspectorSession();
|
|
await session.send({ 'method': 'Runtime.runIfWaitingForDebugger' });
|
|
await session.waitForServerDisconnect();
|
|
strictEqual(42, (await instance.expectShutdown()).exitCode);
|
|
}
|
|
|
|
async function runTest() {
|
|
await testNoServerNoCrash();
|
|
await testNoSessionNoCrash();
|
|
await testSessionNoCrash();
|
|
}
|
|
|
|
runTest();
|