0
0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
nodejs/tools
Rich Trott 22d7dc2212 tools: remove NODE_PATH from environment for tests
Unset NODE_PATH environment variable when running tests.

On Ubuntu 16.04, some users experience test failures due to internal
libraries being installed in /usr/lib/nodejs/internal and NODE_PATH
including /usr/lib/nodejs. Tests that expect internal libraries to be
off limits without the --expose-internals flag will fail in this
situation. Currently, those tests are test/parallel/test-repl.js and
test/parallel/test-internal-modules.js.

This situation seems to (probably) be caused by some
not-entirely-uncommon package that gets installed.

Regardless, tests should ignore the user's NODE_PATH. (NODE_PATH is
tested in test/parallel/test-module-globalpaths-nodepath.js and
test/parallel/test-require-dot.js.)

PR-URL: https://github.com/nodejs/node/pull/11612
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Refs: https://twitter.com/trott/status/835729396900061184
2017-03-02 10:27:52 -08:00
..
configure.d
doc tools: fix lint issue in doctool 2017-03-02 09:50:28 -08:00
eslint eslint: remove dangling eslint symlink 2017-01-12 13:29:36 -08:00
eslint-rules tools,test: enforce assert.ifError with lint rule 2017-01-09 09:20:38 -08:00
gyp tools: add compile_commands.json gyp generator 2017-02-09 22:32:22 +01:00
icu deps: Intl: ICU 58 bump: configure/LICENSE/docs 2016-10-31 13:42:52 -07:00
msvs win,msi: add required UIRef for localized strings 2016-12-20 14:41:23 +00:00
osx-pkg.pmdoc
pkgsrc
rpm
certdata.txt
check-imports.py
compress_json.py src: add /json/protocol endpoint to inspector 2016-09-23 18:51:47 +02:00
cpplint.py
create_android_makefiles
create_expfile.sh build: fix dependencies on AIX 2016-08-29 16:20:18 -04:00
genv8constants.py
getmoduleversion.py
getnodeversion.py
gyp_node.py
install.py build: add correct shared library naming on OS X 2016-08-09 11:55:01 -04:00
js2c.py src: support UTF-8 in compiled-in JS source files 2017-02-13 19:16:14 +01:00
jslint.js
license2rtf.js lib,tools: remove unneeded escaping of / 2016-11-23 22:06:24 -08:00
license-builder.sh deps: switch to v8_inspector in V8 2017-02-22 15:56:58 +01:00
lsan_suppressions.txt
macosx-firewall.sh tools: add macosx-firwall script to avoid popups 2016-12-09 08:31:08 +01:00
make-v8.sh v8: update make-v8.sh to use git 2016-11-09 17:34:22 -05:00
Makefile
mk-ca-bundle.pl
mkssldef.py build: export zlib symbols on Windows 2016-08-08 15:15:48 +02:00
osx-codesign.sh
osx-pkg-postinstall.sh
osx-productsign.sh
release.sh tools: use long format for gpg fingerprint 2016-11-07 10:34:10 -05:00
run-valgrind.py tools: make run-valgrind.py useful 2016-11-15 17:01:24 +01:00
sign.bat win,build: try multiple timeservers when signing 2016-10-19 00:11:02 +11:00
specialize_node_d.py
test-npm-package.js build: add node-inspect integration test 2017-02-13 14:50:29 +01:00
test-npm.sh
test.py tools: remove NODE_PATH from environment for tests 2017-03-02 10:27:52 -08:00
update-authors.sh
utils.py