mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
22d7dc2212
Unset NODE_PATH environment variable when running tests. On Ubuntu 16.04, some users experience test failures due to internal libraries being installed in /usr/lib/nodejs/internal and NODE_PATH including /usr/lib/nodejs. Tests that expect internal libraries to be off limits without the --expose-internals flag will fail in this situation. Currently, those tests are test/parallel/test-repl.js and test/parallel/test-internal-modules.js. This situation seems to (probably) be caused by some not-entirely-uncommon package that gets installed. Regardless, tests should ignore the user's NODE_PATH. (NODE_PATH is tested in test/parallel/test-module-globalpaths-nodepath.js and test/parallel/test-require-dot.js.) PR-URL: https://github.com/nodejs/node/pull/11612 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Refs: https://twitter.com/trott/status/835729396900061184 |
||
---|---|---|
.. | ||
configure.d | ||
doc | ||
eslint | ||
eslint-rules | ||
gyp | ||
icu | ||
msvs | ||
osx-pkg.pmdoc | ||
pkgsrc | ||
rpm | ||
certdata.txt | ||
check-imports.py | ||
compress_json.py | ||
cpplint.py | ||
create_android_makefiles | ||
create_expfile.sh | ||
genv8constants.py | ||
getmoduleversion.py | ||
getnodeversion.py | ||
gyp_node.py | ||
install.py | ||
js2c.py | ||
jslint.js | ||
license2rtf.js | ||
license-builder.sh | ||
lsan_suppressions.txt | ||
macosx-firewall.sh | ||
make-v8.sh | ||
Makefile | ||
mk-ca-bundle.pl | ||
mkssldef.py | ||
osx-codesign.sh | ||
osx-pkg-postinstall.sh | ||
osx-productsign.sh | ||
release.sh | ||
run-valgrind.py | ||
sign.bat | ||
specialize_node_d.py | ||
test-npm-package.js | ||
test-npm.sh | ||
test.py | ||
update-authors.sh | ||
utils.py |