mirror of
https://github.com/nodejs/node.git
synced 2024-11-24 20:29:23 +01:00
bb4dff783d
sequential/test-child-process-execsync and parallel/test-child-process-spawnsync-timeout are both flaky on azure Windows machines, where it may take longer for Node.js to launch and receive output from child processes. These tests work by spawning a child processes that is supposed to sleep for a long time, but the option is configured so that Node.js would terminate them early when a shorter timeout is reached. Then the tests assert that the time taken for the whole thing is shorter than the specified sleep time (meaning the process don't actually get to sleep for that long). To make the tests less brittle on azure Windows, this patch raises the sleep times in those tests on Windows platform, so that the overhead can be taken into account there. PR-URL: https://github.com/nodejs/node/pull/44375 Refs: https://github.com/nodejs/build/issues/3014 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
59 lines
2.2 KiB
JavaScript
59 lines
2.2 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const spawnSync = require('child_process').spawnSync;
|
|
const { debuglog, getSystemErrorName } = require('util');
|
|
const debug = debuglog('test');
|
|
|
|
const TIMER = 200;
|
|
let SLEEP = common.platformTimeout(5000);
|
|
|
|
if (common.isWindows) {
|
|
// Some of the windows machines in the CI need more time to launch
|
|
// and receive output from child processes.
|
|
// https://github.com/nodejs/build/issues/3014
|
|
SLEEP = common.platformTimeout(15000);
|
|
}
|
|
|
|
switch (process.argv[2]) {
|
|
case 'child':
|
|
setTimeout(() => {
|
|
debug('child fired');
|
|
process.exit(1);
|
|
}, SLEEP);
|
|
break;
|
|
default: {
|
|
const start = Date.now();
|
|
const ret = spawnSync(process.execPath, [__filename, 'child'],
|
|
{ timeout: TIMER });
|
|
assert.strictEqual(ret.error.code, 'ETIMEDOUT');
|
|
assert.strictEqual(getSystemErrorName(ret.error.errno), 'ETIMEDOUT');
|
|
const end = Date.now() - start;
|
|
assert(end < SLEEP);
|
|
assert(ret.status > 128 || ret.signal);
|
|
break;
|
|
}
|
|
}
|