mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
380929ec0c
This change removes `common.noop` from the Node.js internal testing
common module.
Over the last few weeks, I've grown to dislike the `common.noop`
abstraction.
First, new (and experienced) contributors are unaware of it and so it
results in a large number of low-value nits on PRs. It also increases
the number of things newcomers and infrequent contributors have to be
aware of to be effective on the project.
Second, it is confusing. Is it a singleton/property or a getter? Which
should be expected? This can lead to subtle and hard-to-find bugs. (To
my knowledge, none have landed on master. But I also think it's only a
matter of time.)
Third, the abstraction is low-value in my opinion. What does it really
get us? A case could me made that it is without value at all.
Lastly, and this is minor, but the abstraction is wordier than not using
the abstraction. `common.noop` doesn't save anything over `() => {}`.
So, I propose removing it.
PR-URL: https://github.com/nodejs/node/pull/12822
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
33 lines
816 B
JavaScript
33 lines
816 B
JavaScript
'use strict';
|
|
|
|
/*
|
|
* This test is a regression test for joyent/node#8897.
|
|
*
|
|
* It tests some private implementation details that should not be
|
|
* considered public interface.
|
|
*/
|
|
const common = require('../common');
|
|
const timers = require('timers');
|
|
|
|
const foo = {
|
|
_onTimeout: common.mustNotCall('_onTimeout should not be called')
|
|
};
|
|
|
|
const bar = {
|
|
_onTimeout: common.mustCall(function() {
|
|
timers.unenroll(foo);
|
|
})
|
|
};
|
|
|
|
// We use timers with expiration times that are sufficiently apart to make
|
|
// sure that they're not fired at the same time on platforms where the timer
|
|
// resolution is a bit coarse (e.g Windows with a default resolution of ~15ms).
|
|
timers.enroll(bar, 1);
|
|
timers._unrefActive(bar);
|
|
|
|
timers.enroll(foo, 50);
|
|
timers._unrefActive(foo);
|
|
|
|
// Keep the process open.
|
|
setTimeout(() => {}, 100);
|