mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
0babd181a0
PR-URL: https://github.com/nodejs/node/pull/17406 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> This is a significant cleanup and refactoring of the cleanup/close/destroy logic for Http2Stream and Http2Session. There are significant changes here in the timing and ordering of cleanup logic, JS apis. and various related necessary edits.
57 lines
1.6 KiB
JavaScript
57 lines
1.6 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
const Countdown = require('../common/countdown');
|
|
|
|
// Only allow one stream to be open at a time
|
|
const server = h2.createServer({ settings: { maxConcurrentStreams: 1 } });
|
|
|
|
// The stream handler must be called only once
|
|
server.on('stream', common.mustCall((stream) => {
|
|
stream.respond();
|
|
stream.end('hello world');
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = h2.connect(`http://localhost:${server.address().port}`);
|
|
|
|
const countdown = new Countdown(2, () => {
|
|
server.close();
|
|
client.close();
|
|
});
|
|
|
|
client.on('remoteSettings', common.mustCall((settings) => {
|
|
assert.strictEqual(settings.maxConcurrentStreams, 1);
|
|
}));
|
|
|
|
// This one should go through with no problems
|
|
{
|
|
const req = client.request({ ':method': 'POST' });
|
|
req.on('aborted', common.mustNotCall());
|
|
req.on('response', common.mustCall());
|
|
req.resume();
|
|
req.on('end', common.mustCall());
|
|
req.on('close', common.mustCall(() => countdown.dec()));
|
|
req.end();
|
|
}
|
|
|
|
{
|
|
// This one should be aborted
|
|
const req = client.request({ ':method': 'POST' });
|
|
req.on('aborted', common.mustCall());
|
|
req.on('response', common.mustNotCall());
|
|
req.resume();
|
|
req.on('end', common.mustCall());
|
|
req.on('close', common.mustCall(() => countdown.dec()));
|
|
req.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_STREAM_ERROR',
|
|
type: Error,
|
|
message: 'Stream closed with error code 7'
|
|
}));
|
|
}
|
|
}));
|