mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
acf56be536
Refactor WriteStream.prototype.close and WriteStream.prototype._destroy to always call the callback passed to close in order. Protects from calling .close() without a callback. Fixes: https://github.com/nodejs/node/issues/17951 See: https://github.com/nodejs/node/pull/15407 PR-URL: https://github.com/nodejs/node/pull/18002 Fixes: https://github.com/nodejs/node/issues/17951 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
58 lines
1.7 KiB
JavaScript
58 lines
1.7 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
|
|
const file = path.join(common.tmpDir, 'write-autoclose-opt1.txt');
|
|
common.refreshTmpDir();
|
|
let stream = fs.createWriteStream(file, { flags: 'w+', autoClose: false });
|
|
stream.write('Test1');
|
|
stream.end();
|
|
stream.on('finish', common.mustCall(function() {
|
|
stream.on('close', common.mustNotCall());
|
|
process.nextTick(common.mustCall(function() {
|
|
assert.strictEqual(stream.closed, false);
|
|
assert.notStrictEqual(stream.fd, null);
|
|
next();
|
|
}));
|
|
}));
|
|
|
|
function next() {
|
|
// This will tell us if the fd is usable again or not
|
|
stream = fs.createWriteStream(null, { fd: stream.fd, start: 0 });
|
|
stream.write('Test2');
|
|
stream.end();
|
|
stream.on('finish', common.mustCall(function() {
|
|
assert.strictEqual(stream.closed, false);
|
|
assert.strictEqual(stream.fd, null);
|
|
stream.on('close', common.mustCall(function() {
|
|
assert.strictEqual(stream.closed, true);
|
|
process.nextTick(next2);
|
|
}));
|
|
}));
|
|
}
|
|
|
|
function next2() {
|
|
// This will test if after reusing the fd data is written properly
|
|
fs.readFile(file, function(err, data) {
|
|
assert.ifError(err);
|
|
assert.strictEqual(data.toString(), 'Test2');
|
|
process.nextTick(common.mustCall(next3));
|
|
});
|
|
}
|
|
|
|
function next3() {
|
|
// This is to test success scenario where autoClose is true
|
|
const stream = fs.createWriteStream(file, { autoClose: true });
|
|
stream.write('Test3');
|
|
stream.end();
|
|
stream.on('finish', common.mustCall(function() {
|
|
assert.strictEqual(stream.closed, false);
|
|
assert.strictEqual(stream.fd, null);
|
|
stream.on('close', common.mustCall(function() {
|
|
assert.strictEqual(stream.closed, true);
|
|
}));
|
|
}));
|
|
}
|