mirror of
https://github.com/nodejs/node.git
synced 2024-11-30 07:27:22 +01:00
430d94ef85
When there is an error that is thrown in a nextTick function, which is
then handled by a domain or other process.on('uncaughtException')
handler, if the error handler *also* adds a nextTick and triggers
multiple MakeCallback events (ie, by doing some I/O), then it would
skip over the tickDepth check, resulting in an infinite spin.
Solution: Check the tickDepth at the start of the tick processing, and
preserve it when we are cleaning up in the error case or exiting early
in the re-entry case.
In order to make sure that tick callbacks are *eventually* handled, any
callback triggered by the underlying spinner in libuv will be processed
as if starting from a tick depth of 0.
70 lines
2.1 KiB
JavaScript
70 lines
2.1 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
|
|
if (process.argv[2] !== 'child') {
|
|
var spawn = require('child_process').spawn;
|
|
var child = spawn(process.execPath, [__filename, 'child'], {
|
|
stdio: 'pipe'//'inherit'
|
|
});
|
|
var timer = setTimeout(function() {
|
|
throw new Error('child is hung');
|
|
}, 500);
|
|
child.on('exit', function(code) {
|
|
console.error('ok');
|
|
assert(!code);
|
|
clearTimeout(timer);
|
|
});
|
|
} else {
|
|
|
|
var domain = require('domain');
|
|
var d = domain.create();
|
|
process.maxTickDepth = 10;
|
|
|
|
// in the error handler, we trigger several MakeCallback events
|
|
d.on('error', function(e) {
|
|
console.log('a')
|
|
console.log('b')
|
|
console.log('c')
|
|
console.log('d')
|
|
console.log('e')
|
|
f();
|
|
});
|
|
|
|
function f() {
|
|
process.nextTick(function() {
|
|
d.run(function() {
|
|
throw(new Error('x'));
|
|
});
|
|
});
|
|
}
|
|
|
|
f();
|
|
setTimeout(function () {
|
|
console.error('broke in!');
|
|
//process.stdout.close();
|
|
//process.stderr.close();
|
|
process.exit(0);
|
|
});
|
|
}
|