mirror of
https://github.com/nodejs/node.git
synced 2024-11-30 07:27:22 +01:00
0c2960ef4a
Add range checks for the offset, length and port arguments to
dgram.Socket#send(). Fixes the following assertion:
node: ../../src/udp_wrap.cc:264: static v8::Handle<v8::Value>
node::UDPWrap::DoSend(const v8::Arguments&, int): Assertion
`offset < Buffer::Length(buffer_obj)' failed.
And:
node: ../../src/udp_wrap.cc:265: static v8::Handle<v8::Value>
node::UDPWrap::DoSend(const v8::Arguments&, int): Assertion
`length <= Buffer::Length(buffer_obj) - offset' failed.
Interestingly enough, a negative port number was accepted until now but
silently ignored. (In other words, it would send the datagram to a
random port.)
This commit exposed a bug in the simple/test-dgram-close test which
has also been fixed.
This is a back-port of commit 41ec6d0 from the master branch.
Fixes #6025.
41 lines
1.9 KiB
JavaScript
41 lines
1.9 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var dgram = require('dgram');
|
|
|
|
var buf = Buffer('test');
|
|
var host = '127.0.0.1';
|
|
var sock = dgram.createSocket('udp4');
|
|
|
|
assert.throws(function() {
|
|
sock.send();
|
|
}, TypeError); // First argument should be a buffer.
|
|
|
|
assert.throws(function() { sock.send(buf, -1, 1, 1, host); }, RangeError);
|
|
assert.throws(function() { sock.send(buf, 1, -1, 1, host); }, RangeError);
|
|
assert.throws(function() { sock.send(buf, 1, 1, -1, host); }, RangeError);
|
|
assert.throws(function() { sock.send(buf, 5, 1, 1, host); }, RangeError);
|
|
assert.throws(function() { sock.send(buf, 1, 5, 1, host); }, RangeError);
|
|
assert.throws(function() { sock.send(buf, 1, 1, 0, host); }, RangeError);
|
|
assert.throws(function() { sock.send(buf, 1, 1, 65536, host); }, RangeError);
|