mirror of
https://github.com/nodejs/node.git
synced 2024-11-25 08:19:38 +01:00
0cff0521c3
This commit restricts socket timeouts non-negative, finite numbers. Any other value throws a TypeError or RangeError. This prevents subtle bugs that can happen due to type coercion. Fixes: https://github.com/joyent/node/issues/8618 PR-URL: https://github.com/joyent/node/pull/8884 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com> Conflicts: lib/timers.js test/simple/test-net-settimeout.js test/simple/test-net-socket-timeout.js
36 lines
811 B
JavaScript
36 lines
811 B
JavaScript
// This example sets a timeout then immediately attempts to disable the timeout
|
|
// https://github.com/joyent/node/pull/2245
|
|
|
|
var common = require('../common');
|
|
var net = require('net');
|
|
var assert = require('assert');
|
|
|
|
var T = 100;
|
|
|
|
var server = net.createServer(function(c) {
|
|
c.write('hello');
|
|
});
|
|
server.listen(common.PORT);
|
|
|
|
var killers = [0];
|
|
|
|
var left = killers.length;
|
|
killers.forEach(function(killer) {
|
|
var socket = net.createConnection(common.PORT, 'localhost');
|
|
|
|
socket.setTimeout(T, function() {
|
|
socket.destroy();
|
|
if (--left === 0) server.close();
|
|
assert.ok(killer !== 0);
|
|
clearTimeout(timeout);
|
|
});
|
|
|
|
socket.setTimeout(killer);
|
|
|
|
var timeout = setTimeout(function() {
|
|
socket.destroy();
|
|
if (--left === 0) server.close();
|
|
assert.ok(killer === 0);
|
|
}, T * 2);
|
|
});
|