mirror of
https://github.com/nodejs/node.git
synced 2024-11-28 22:46:31 +01:00
ecef87177a
Currently, nullCheck() will attempt to invoke any truthy value as a function if the path argument contains a null character. This commit validates that the callback is actually a function before trying to invoke it. fs.access() was vulnerable to this bug, as nullCheck() was called prior to type checking its callback. PR-URL: https://github.com/iojs/io.js/pull/887 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
83 lines
2.0 KiB
JavaScript
83 lines
2.0 KiB
JavaScript
var common = require('../common');
|
|
var assert = require('assert');
|
|
var fs = require('fs');
|
|
var path = require('path');
|
|
var doesNotExist = __filename + '__this_should_not_exist';
|
|
var readOnlyFile = path.join(common.tmpDir, 'read_only_file');
|
|
|
|
var removeFile = function(file) {
|
|
try {
|
|
fs.unlinkSync(file);
|
|
} catch (err) {
|
|
// Ignore error
|
|
}
|
|
};
|
|
|
|
var createReadOnlyFile = function(file) {
|
|
removeFile(file);
|
|
fs.writeFileSync(file, '');
|
|
fs.chmodSync(file, 0444);
|
|
};
|
|
|
|
createReadOnlyFile(readOnlyFile);
|
|
|
|
assert(typeof fs.F_OK === 'number');
|
|
assert(typeof fs.R_OK === 'number');
|
|
assert(typeof fs.W_OK === 'number');
|
|
assert(typeof fs.X_OK === 'number');
|
|
|
|
fs.access(__filename, function(err) {
|
|
assert.strictEqual(err, null, 'error should not exist');
|
|
});
|
|
|
|
fs.access(__filename, fs.R_OK, function(err) {
|
|
assert.strictEqual(err, null, 'error should not exist');
|
|
});
|
|
|
|
fs.access(doesNotExist, function(err) {
|
|
assert.notEqual(err, null, 'error should exist');
|
|
assert.strictEqual(err.code, 'ENOENT');
|
|
assert.strictEqual(err.path, doesNotExist);
|
|
});
|
|
|
|
fs.access(readOnlyFile, fs.F_OK | fs.R_OK, function(err) {
|
|
assert.strictEqual(err, null, 'error should not exist');
|
|
});
|
|
|
|
fs.access(readOnlyFile, fs.W_OK, function(err) {
|
|
assert.notEqual(err, null, 'error should exist');
|
|
assert.strictEqual(err.path, readOnlyFile);
|
|
});
|
|
|
|
assert.throws(function() {
|
|
fs.access(100, fs.F_OK, function(err) {});
|
|
}, /path must be a string/);
|
|
|
|
assert.throws(function() {
|
|
fs.access(__filename, fs.F_OK);
|
|
}, /callback must be a function/);
|
|
|
|
assert.throws(function() {
|
|
fs.access(__filename, fs.F_OK, {});
|
|
}, /callback must be a function/);
|
|
|
|
assert.doesNotThrow(function() {
|
|
fs.accessSync(__filename);
|
|
});
|
|
|
|
assert.doesNotThrow(function() {
|
|
var mode = fs.F_OK | fs.R_OK | fs.W_OK;
|
|
|
|
fs.accessSync(__filename, mode);
|
|
});
|
|
|
|
assert.throws(function() {
|
|
fs.accessSync(doesNotExist);
|
|
}, function (err) {
|
|
return err.code === 'ENOENT' && err.path === doesNotExist;
|
|
});
|
|
|
|
process.on('exit', function() {
|
|
removeFile(readOnlyFile);
|
|
});
|