Anna Henningsen 25447d82d3 src: unregister Isolate with platform before disposing ... I previously thought the order of these calls was no longer relevant. I was wrong. This commit undoes the changes from 312c02d25e, adds a comment explaining why I was wrong, and flips the order of the calls elsewhere for consistency, the latter having been the goal of 312c02d25e. Fixes: https://github.com/nodejs/node/issues/30846 Refs: https://github.com/nodejs/node/pull/30181 PR-URL: https://github.com/nodejs/node/pull/30909 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>		2019-12-14 16:32:52 -05:00
..
gtest
node_test_fixture.cc	src: add abstract IsolatePlatformDelegate	2019-11-20 19:02:55 +01:00
node_test_fixture.h	src: unregister Isolate with platform before disposing	2019-12-14 16:32:52 -05:00
test_aliased_buffer.cc
test_base64.cc
test_base_object_ptr.cc	src: introduce custom smart pointers for BaseObjects	2019-11-19 13:47:29 +01:00
test_environment.cc	buffer: release buffers with free callbacks on env exit	2019-11-30 02:02:50 +01:00
test_inspector_socket_server.cc	inspector: added --inspect-publish-uid	2019-06-03 18:15:04 +03:00
test_inspector_socket.cc
test_linked_binding.cc	src: allow adding linked bindings to Environment	2019-11-07 19:51:11 -08:00
test_node_postmortem_metadata.cc	src: introduce custom smart pointers for BaseObjects	2019-11-19 13:47:29 +01:00
test_per_process.cc	tools: fix js2c regression	2019-06-02 12:03:40 +02:00
test_platform.cc	src: unregister Isolate with platform before disposing	2019-12-14 16:32:52 -05:00
test_report_util.cc
test_traced_value.cc
test_url.cc
test_util.cc