mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
79 lines
2.4 KiB
JavaScript
79 lines
2.4 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const stream = require('stream');
|
|
|
|
class MyWritable extends stream.Writable {
|
|
constructor(fn, options) {
|
|
super(options);
|
|
this.fn = fn;
|
|
}
|
|
|
|
_write(chunk, encoding, callback) {
|
|
this.fn(Buffer.isBuffer(chunk), typeof chunk, encoding);
|
|
callback();
|
|
}
|
|
}
|
|
|
|
(function defaultCondingIsUtf8() {
|
|
const m = new MyWritable(function(isBuffer, type, enc) {
|
|
assert.strictEqual(enc, 'utf8');
|
|
}, { decodeStrings: false });
|
|
m.write('foo');
|
|
m.end();
|
|
}());
|
|
|
|
(function changeDefaultEncodingToAscii() {
|
|
const m = new MyWritable(function(isBuffer, type, enc) {
|
|
assert.strictEqual(enc, 'ascii');
|
|
}, { decodeStrings: false });
|
|
m.setDefaultEncoding('ascii');
|
|
m.write('bar');
|
|
m.end();
|
|
}());
|
|
|
|
// Change default encoding to invalid value.
|
|
assert.throws(() => {
|
|
const m = new MyWritable(
|
|
(isBuffer, type, enc) => {},
|
|
{ decodeStrings: false });
|
|
m.setDefaultEncoding({});
|
|
m.write('bar');
|
|
m.end();
|
|
}, {
|
|
name: 'TypeError',
|
|
code: 'ERR_UNKNOWN_ENCODING',
|
|
message: 'Unknown encoding: {}'
|
|
});
|
|
|
|
(function checkVairableCaseEncoding() {
|
|
const m = new MyWritable(function(isBuffer, type, enc) {
|
|
assert.strictEqual(enc, 'ascii');
|
|
}, { decodeStrings: false });
|
|
m.setDefaultEncoding('AsCii');
|
|
m.write('bar');
|
|
m.end();
|
|
}());
|