mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
63 lines
1.6 KiB
JavaScript
63 lines
1.6 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
const server = h2.createServer();
|
|
|
|
// We use the lower-level API here
|
|
server.on('stream', common.mustCall((stream) => {
|
|
stream.setTimeout(1, common.mustCall(() => {
|
|
stream.respond({ ':status': 200 });
|
|
stream.end('hello world');
|
|
}));
|
|
|
|
// Check that expected errors are thrown with wrong args
|
|
assert.throws(
|
|
() => stream.setTimeout('100'),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message:
|
|
'The "msecs" argument must be of type number. Received type string' +
|
|
" ('100')"
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => stream.setTimeout(0, Symbol('test')),
|
|
{
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
name: 'TypeError',
|
|
message: 'Callback must be a function. Received Symbol(test)'
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => stream.setTimeout(100, {}),
|
|
{
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
name: 'TypeError',
|
|
message: 'Callback must be a function. Received {}'
|
|
}
|
|
);
|
|
}));
|
|
server.listen(0);
|
|
|
|
server.on('listening', common.mustCall(() => {
|
|
const client = h2.connect(`http://localhost:${server.address().port}`);
|
|
client.setTimeout(1, common.mustCall(() => {
|
|
const req = client.request({ ':path': '/' });
|
|
req.setTimeout(1, common.mustCall(() => {
|
|
req.on('response', common.mustCall());
|
|
req.resume();
|
|
req.on('end', common.mustCall(() => {
|
|
server.close();
|
|
client.close();
|
|
}));
|
|
req.end();
|
|
}));
|
|
}));
|
|
}));
|