mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
125 lines
2.9 KiB
JavaScript
125 lines
2.9 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const fixtures = require('../common/fixtures');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
const fs = require('fs');
|
|
|
|
const optionsWithTypeError = {
|
|
offset: 'number',
|
|
length: 'number',
|
|
statCheck: 'function'
|
|
};
|
|
|
|
const types = {
|
|
boolean: true,
|
|
function: () => {},
|
|
number: 1,
|
|
object: {},
|
|
array: [],
|
|
null: null,
|
|
symbol: Symbol('test')
|
|
};
|
|
|
|
const fname = fixtures.path('elipses.txt');
|
|
const fd = fs.openSync(fname, 'r');
|
|
|
|
const server = http2.createServer();
|
|
|
|
server.on('stream', common.mustCall((stream) => {
|
|
// Should throw if fd isn't a number
|
|
Object.keys(types).forEach((type) => {
|
|
if (type === 'number') {
|
|
return;
|
|
}
|
|
|
|
assert.throws(
|
|
() => stream.respondWithFD(types[type], {
|
|
'content-type': 'text/plain'
|
|
}),
|
|
{
|
|
name: 'TypeError',
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: 'The "fd" argument must be of type number or an instance of' +
|
|
` FileHandle.${common.invalidArgTypeHelper(types[type])}`
|
|
}
|
|
);
|
|
});
|
|
|
|
// Check for all possible TypeError triggers on options
|
|
Object.keys(optionsWithTypeError).forEach((option) => {
|
|
Object.keys(types).forEach((type) => {
|
|
if (type === optionsWithTypeError[option]) {
|
|
return;
|
|
}
|
|
|
|
assert.throws(
|
|
() => stream.respondWithFD(fd, {
|
|
'content-type': 'text/plain'
|
|
}, {
|
|
[option]: types[type]
|
|
}),
|
|
{
|
|
name: 'TypeError',
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
message: `The value "${String(types[type])}" is invalid ` +
|
|
`for option "${option}"`
|
|
}
|
|
);
|
|
});
|
|
});
|
|
|
|
// Should throw if :status 204, 205 or 304
|
|
[204, 205, 304].forEach((status) => assert.throws(
|
|
() => stream.respondWithFD(fd, {
|
|
'content-type': 'text/plain',
|
|
':status': status,
|
|
}),
|
|
{
|
|
code: 'ERR_HTTP2_PAYLOAD_FORBIDDEN',
|
|
name: 'Error',
|
|
message: `Responses with ${status} status must not have a payload`
|
|
}
|
|
));
|
|
|
|
// Should throw if headers already sent
|
|
stream.respond();
|
|
assert.throws(
|
|
() => stream.respondWithFD(fd, {
|
|
'content-type': 'text/plain'
|
|
}),
|
|
{
|
|
code: 'ERR_HTTP2_HEADERS_SENT',
|
|
name: 'Error',
|
|
message: 'Response has already been initiated.'
|
|
}
|
|
);
|
|
|
|
// Should throw if stream already destroyed
|
|
stream.destroy();
|
|
assert.throws(
|
|
() => stream.respondWithFD(fd, {
|
|
'content-type': 'text/plain'
|
|
}),
|
|
{
|
|
code: 'ERR_HTTP2_INVALID_STREAM',
|
|
name: 'Error',
|
|
message: 'The stream has been destroyed'
|
|
}
|
|
);
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
const req = client.request();
|
|
|
|
req.on('close', common.mustCall(() => {
|
|
client.close();
|
|
server.close();
|
|
}));
|
|
req.end();
|
|
}));
|