mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
89 lines
2.3 KiB
JavaScript
89 lines
2.3 KiB
JavaScript
'use strict';
|
|
// Flags: --expose-internals
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const http2 = require('http2');
|
|
const { internalBinding } = require('internal/test/binding');
|
|
const {
|
|
constants,
|
|
Http2Stream,
|
|
nghttp2ErrorString
|
|
} = internalBinding('http2');
|
|
const { NghttpError } = require('internal/http2/util');
|
|
|
|
// Tests error handling within additionalHeaders
|
|
// - every other NGHTTP2 error from binding (should emit stream error)
|
|
|
|
const specificTestKeys = [];
|
|
const specificTests = [];
|
|
|
|
const genericTests = Object.getOwnPropertyNames(constants)
|
|
.filter((key) => (
|
|
key.indexOf('NGHTTP2_ERR') === 0 && specificTestKeys.indexOf(key) < 0
|
|
))
|
|
.map((key) => ({
|
|
ngError: constants[key],
|
|
error: {
|
|
code: 'ERR_HTTP2_ERROR',
|
|
constructor: NghttpError,
|
|
name: 'Error',
|
|
message: nghttp2ErrorString(constants[key])
|
|
},
|
|
type: 'stream'
|
|
}));
|
|
|
|
|
|
const tests = specificTests.concat(genericTests);
|
|
|
|
let currentError;
|
|
|
|
// Mock sendHeaders because we only care about testing error handling
|
|
Http2Stream.prototype.info = () => currentError.ngError;
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', common.mustCall((stream, headers) => {
|
|
const errorMustCall = common.expectsError(currentError.error);
|
|
const errorMustNotCall = common.mustNotCall(
|
|
`${currentError.error.code} should emit on ${currentError.type}`
|
|
);
|
|
|
|
if (currentError.type === 'stream') {
|
|
stream.session.on('error', errorMustNotCall);
|
|
stream.on('error', errorMustCall);
|
|
} else {
|
|
stream.session.once('error', errorMustCall);
|
|
stream.on('error', errorMustNotCall);
|
|
}
|
|
|
|
stream.additionalHeaders({ ':status': 100 });
|
|
}, tests.length));
|
|
|
|
server.listen(0, common.mustCall(() => runTest(tests.shift())));
|
|
|
|
function runTest(test) {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
const req = client.request({ ':method': 'POST' });
|
|
|
|
currentError = test;
|
|
req.resume();
|
|
req.end();
|
|
|
|
req.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_STREAM_ERROR',
|
|
name: 'Error',
|
|
message: 'Stream closed with error code NGHTTP2_INTERNAL_ERROR'
|
|
}));
|
|
|
|
req.on('close', common.mustCall(() => {
|
|
client.close();
|
|
|
|
if (!tests.length) {
|
|
server.close();
|
|
} else {
|
|
runTest(tests.shift());
|
|
}
|
|
}));
|
|
}
|