mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
0df581c307
Ensure that the callback of `OutgoingMessage.prototype.write()` is called even when writing empty chunks. Fixes: https://github.com/nodejs/node/issues/22066 PR-URL: https://github.com/nodejs/node/pull/27709 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
37 lines
844 B
JavaScript
37 lines
844 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { OutgoingMessage } = require('http');
|
|
const { Writable } = require('stream');
|
|
const assert = require('assert');
|
|
|
|
// Check that OutgoingMessage can be used without a proper Socket
|
|
// Fixes: https://github.com/nodejs/node/issues/14386
|
|
// Fixes: https://github.com/nodejs/node/issues/14381
|
|
|
|
class Response extends OutgoingMessage {
|
|
_implicitHeader() {}
|
|
}
|
|
|
|
const res = new Response();
|
|
|
|
let firstChunk = true;
|
|
|
|
const ws = new Writable({
|
|
write: common.mustCall((chunk, encoding, callback) => {
|
|
if (firstChunk) {
|
|
assert(chunk.toString().endsWith('hello world'));
|
|
firstChunk = false;
|
|
} else {
|
|
assert.strictEqual(chunk.length, 0);
|
|
}
|
|
setImmediate(callback);
|
|
}, 2)
|
|
});
|
|
|
|
res.socket = ws;
|
|
ws._httpMessage = res;
|
|
res.connection = ws;
|
|
|
|
res.end('hello world');
|