mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
93 lines
2.2 KiB
JavaScript
93 lines
2.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
tmpdir.refresh();
|
|
|
|
const expected = 'ümlaut. Лорем 運務ホソモ指及 आपको करने विकास 紙読決多密所 أضف';
|
|
|
|
const getFileName = (i) => path.join(tmpdir.path, `writev_${i}.txt`);
|
|
|
|
/**
|
|
* Testing with a array of buffers input
|
|
*/
|
|
|
|
// fs.writev with array of buffers with all parameters
|
|
{
|
|
const filename = getFileName(1);
|
|
const fd = fs.openSync(filename, 'w');
|
|
|
|
const buffer = Buffer.from(expected);
|
|
const bufferArr = [buffer, buffer];
|
|
|
|
const done = common.mustCall((err, written, buffers) => {
|
|
assert.ifError(err);
|
|
|
|
assert.deepStrictEqual(bufferArr, buffers);
|
|
const expectedLength = bufferArr.length * buffer.byteLength;
|
|
assert.deepStrictEqual(written, expectedLength);
|
|
fs.closeSync(fd);
|
|
|
|
assert(Buffer.concat(bufferArr).equals(fs.readFileSync(filename)));
|
|
});
|
|
|
|
fs.writev(fd, bufferArr, null, done);
|
|
}
|
|
|
|
// fs.writev with array of buffers without position
|
|
{
|
|
const filename = getFileName(2);
|
|
const fd = fs.openSync(filename, 'w');
|
|
|
|
const buffer = Buffer.from(expected);
|
|
const bufferArr = [buffer, buffer];
|
|
|
|
const done = common.mustCall((err, written, buffers) => {
|
|
assert.ifError(err);
|
|
|
|
assert.deepStrictEqual(bufferArr, buffers);
|
|
|
|
const expectedLength = bufferArr.length * buffer.byteLength;
|
|
assert.deepStrictEqual(written, expectedLength);
|
|
fs.closeSync(fd);
|
|
|
|
assert(Buffer.concat(bufferArr).equals(fs.readFileSync(filename)));
|
|
});
|
|
|
|
fs.writev(fd, bufferArr, done);
|
|
}
|
|
|
|
/**
|
|
* Testing with wrong input types
|
|
*/
|
|
{
|
|
const filename = getFileName(3);
|
|
const fd = fs.openSync(filename, 'w');
|
|
|
|
[false, 'test', {}, [{}], ['sdf'], null, undefined].forEach((i) => {
|
|
assert.throws(
|
|
() => fs.writev(fd, i, null, common.mustNotCall()), {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
}
|
|
);
|
|
});
|
|
|
|
fs.closeSync(fd);
|
|
}
|
|
|
|
// fs.writev with wrong fd types
|
|
[false, 'test', {}, [{}], null, undefined].forEach((i) => {
|
|
assert.throws(
|
|
() => fs.writev(i, common.mustNotCall()),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
}
|
|
);
|
|
});
|