mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
fb6df3bfac
The input was not validated so far and that caused unwanted side effects. E.g., `undefined` became the string `'undefined'`. It was expected to fail or to end up as empty string. Now all input is validated to be either some type of array buffer view or a string. That way it's always clear what the user intents. PR-URL: https://github.com/nodejs/node/pull/31030 Fixes: https://github.com/nodejs/node/issues/31025 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
170 lines
5.0 KiB
JavaScript
170 lines
5.0 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
// Flags: --expose_externalize_string
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
tmpdir.refresh();
|
|
|
|
const fn = path.join(tmpdir.path, 'write.txt');
|
|
const fn2 = path.join(tmpdir.path, 'write2.txt');
|
|
const fn3 = path.join(tmpdir.path, 'write3.txt');
|
|
const expected = 'ümlaut.';
|
|
const constants = fs.constants;
|
|
|
|
/* eslint-disable no-undef */
|
|
common.allowGlobals(externalizeString, isOneByteString, x);
|
|
|
|
{
|
|
const expected = 'ümlaut eins'; // Must be a unique string.
|
|
externalizeString(expected);
|
|
assert.strictEqual(isOneByteString(expected), true);
|
|
const fd = fs.openSync(fn, 'w');
|
|
fs.writeSync(fd, expected, 0, 'latin1');
|
|
fs.closeSync(fd);
|
|
assert.strictEqual(fs.readFileSync(fn, 'latin1'), expected);
|
|
}
|
|
|
|
{
|
|
const expected = 'ümlaut zwei'; // Must be a unique string.
|
|
externalizeString(expected);
|
|
assert.strictEqual(isOneByteString(expected), true);
|
|
const fd = fs.openSync(fn, 'w');
|
|
fs.writeSync(fd, expected, 0, 'utf8');
|
|
fs.closeSync(fd);
|
|
assert.strictEqual(fs.readFileSync(fn, 'utf8'), expected);
|
|
}
|
|
|
|
{
|
|
const expected = '中文 1'; // Must be a unique string.
|
|
externalizeString(expected);
|
|
assert.strictEqual(isOneByteString(expected), false);
|
|
const fd = fs.openSync(fn, 'w');
|
|
fs.writeSync(fd, expected, 0, 'ucs2');
|
|
fs.closeSync(fd);
|
|
assert.strictEqual(fs.readFileSync(fn, 'ucs2'), expected);
|
|
}
|
|
|
|
{
|
|
const expected = '中文 2'; // Must be a unique string.
|
|
externalizeString(expected);
|
|
assert.strictEqual(isOneByteString(expected), false);
|
|
const fd = fs.openSync(fn, 'w');
|
|
fs.writeSync(fd, expected, 0, 'utf8');
|
|
fs.closeSync(fd);
|
|
assert.strictEqual(fs.readFileSync(fn, 'utf8'), expected);
|
|
}
|
|
/* eslint-enable no-undef */
|
|
|
|
fs.open(fn, 'w', 0o644, common.mustCall((err, fd) => {
|
|
assert.ifError(err);
|
|
|
|
const done = common.mustCall((err, written) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(written, Buffer.byteLength(expected));
|
|
fs.closeSync(fd);
|
|
const found = fs.readFileSync(fn, 'utf8');
|
|
fs.unlinkSync(fn);
|
|
assert.strictEqual(found, expected);
|
|
});
|
|
|
|
const written = common.mustCall((err, written) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(written, 0);
|
|
fs.write(fd, expected, 0, 'utf8', done);
|
|
});
|
|
|
|
fs.write(fd, '', 0, 'utf8', written);
|
|
}));
|
|
|
|
const args = constants.O_CREAT | constants.O_WRONLY | constants.O_TRUNC;
|
|
fs.open(fn2, args, 0o644, common.mustCall((err, fd) => {
|
|
assert.ifError(err);
|
|
|
|
const done = common.mustCall((err, written) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(written, Buffer.byteLength(expected));
|
|
fs.closeSync(fd);
|
|
const found = fs.readFileSync(fn2, 'utf8');
|
|
fs.unlinkSync(fn2);
|
|
assert.strictEqual(found, expected);
|
|
});
|
|
|
|
const written = common.mustCall((err, written) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(written, 0);
|
|
fs.write(fd, expected, 0, 'utf8', done);
|
|
});
|
|
|
|
fs.write(fd, '', 0, 'utf8', written);
|
|
}));
|
|
|
|
fs.open(fn3, 'w', 0o644, common.mustCall((err, fd) => {
|
|
assert.ifError(err);
|
|
|
|
const done = common.mustCall((err, written) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(written, Buffer.byteLength(expected));
|
|
fs.closeSync(fd);
|
|
});
|
|
|
|
fs.write(fd, expected, done);
|
|
}));
|
|
|
|
[false, 'test', {}, [], null, undefined].forEach((i) => {
|
|
assert.throws(
|
|
() => fs.write(i, common.mustNotCall()),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => fs.writeSync(i),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
}
|
|
);
|
|
});
|
|
|
|
[false, 5, {}, [], null, undefined].forEach((data) => {
|
|
assert.throws(
|
|
() => fs.write(1, data, common.mustNotCall()),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: /"buffer"/
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => fs.writeSync(1, data),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: /"buffer"/
|
|
}
|
|
);
|
|
});
|