mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
f17f467544
Currently, configuring --without-ssl will cause the lint-js target to
fail with the following error:
$ make lint-js
Running JS linter...
internal/util.js:101
throw new ERR_NO_CRYPTO();
^
Error [ERR_NO_CRYPTO]:
Node.js is not compiled with OpenSSL crypto support
at assertCrypto (internal/util.js:101:11)
at crypto.js:31:1
...
(/node/tools/node_modules/eslint/node_modules/file-entry-cache/
cache.js:2:14)
at Module._compile (internal/modules/cjs/loader.js:746:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:757:10)
make: *** [lint-js] Error 1
There are also a number of tests that are affected in a similar way.
This commit adds crypto checks to allow for lint-js and the affected
tests to be skipped when configured --without-ssl.
PR-URL: https://github.com/nodejs/node/pull/26182
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
57 lines
1.5 KiB
JavaScript
57 lines
1.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
common.skipIfEslintMissing();
|
|
|
|
const RuleTester = require('../../tools/node_modules/eslint').RuleTester;
|
|
const rule = require('../../tools/eslint-rules/prefer-assert-methods');
|
|
|
|
new RuleTester().run('prefer-assert-methods', rule, {
|
|
valid: [
|
|
'assert.strictEqual(foo, bar);',
|
|
'assert(foo === bar && baz);',
|
|
'assert.notStrictEqual(foo, bar);',
|
|
'assert(foo !== bar && baz);',
|
|
'assert.equal(foo, bar);',
|
|
'assert(foo == bar && baz);',
|
|
'assert.notEqual(foo, bar);',
|
|
'assert(foo != bar && baz);',
|
|
'assert.ok(foo);',
|
|
'assert.ok(foo != bar);',
|
|
'assert.ok(foo === bar && baz);'
|
|
],
|
|
invalid: [
|
|
{
|
|
code: 'assert(foo == bar);',
|
|
errors: [{
|
|
message: "'assert.equal' should be used instead of '=='"
|
|
}],
|
|
output: 'assert.equal(foo, bar);'
|
|
},
|
|
{
|
|
code: 'assert(foo === bar);',
|
|
errors: [{
|
|
message: "'assert.strictEqual' should be used instead of '==='"
|
|
}],
|
|
output: 'assert.strictEqual(foo, bar);'
|
|
},
|
|
{
|
|
code: 'assert(foo != bar);',
|
|
errors: [{
|
|
message: "'assert.notEqual' should be used instead of '!='"
|
|
}],
|
|
output: 'assert.notEqual(foo, bar);'
|
|
},
|
|
{
|
|
code: 'assert(foo !== bar);',
|
|
errors: [{
|
|
message: "'assert.notStrictEqual' should be used instead of '!=='"
|
|
}],
|
|
output: 'assert.notStrictEqual(foo, bar);'
|
|
}
|
|
]
|
|
});
|