mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
318 lines
9.5 KiB
JavaScript
318 lines
9.5 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
// Flags: --pending-deprecation
|
|
'use strict';
|
|
const common = require('../common');
|
|
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const crypto = require('crypto');
|
|
const { kMaxLength } = require('buffer');
|
|
const { inspect } = require('util');
|
|
|
|
const kMaxUint32 = Math.pow(2, 32) - 1;
|
|
const kMaxPossibleLength = Math.min(kMaxLength, kMaxUint32);
|
|
|
|
// Bump, we register a lot of exit listeners
|
|
process.setMaxListeners(256);
|
|
|
|
common.expectWarning('DeprecationWarning',
|
|
'crypto.pseudoRandomBytes is deprecated.', 'DEP0115');
|
|
|
|
{
|
|
[crypto.randomBytes, crypto.pseudoRandomBytes].forEach((f) => {
|
|
[undefined, null, false, true, {}, []].forEach((value) => {
|
|
const errObj = {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "size" argument must be of type number.' +
|
|
common.invalidArgTypeHelper(value)
|
|
};
|
|
assert.throws(() => f(value), errObj);
|
|
assert.throws(() => f(value, common.mustNotCall()), errObj);
|
|
});
|
|
|
|
[-1, NaN, 2 ** 32].forEach((value) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "size" is out of range. It must be >= 0 && <= ' +
|
|
`${kMaxPossibleLength}. Received ${value}`
|
|
};
|
|
assert.throws(() => f(value), errObj);
|
|
assert.throws(() => f(value, common.mustNotCall()), errObj);
|
|
});
|
|
|
|
[0, 1, 2, 4, 16, 256, 1024, 101.2].forEach((len) => {
|
|
f(len, common.mustCall((ex, buf) => {
|
|
assert.strictEqual(ex, null);
|
|
assert.strictEqual(buf.length, Math.floor(len));
|
|
assert.ok(Buffer.isBuffer(buf));
|
|
}));
|
|
});
|
|
});
|
|
}
|
|
|
|
{
|
|
const buf = Buffer.alloc(10);
|
|
const before = buf.toString('hex');
|
|
const after = crypto.randomFillSync(buf).toString('hex');
|
|
assert.notStrictEqual(before, after);
|
|
}
|
|
|
|
{
|
|
const buf = new Uint8Array(new Array(10).fill(0));
|
|
const before = Buffer.from(buf).toString('hex');
|
|
crypto.randomFillSync(buf);
|
|
const after = Buffer.from(buf).toString('hex');
|
|
assert.notStrictEqual(before, after);
|
|
}
|
|
|
|
{
|
|
[
|
|
new Uint16Array(10),
|
|
new Uint32Array(10),
|
|
new Float32Array(10),
|
|
new Float64Array(10),
|
|
new DataView(new ArrayBuffer(10))
|
|
].forEach((buf) => {
|
|
const before = Buffer.from(buf.buffer).toString('hex');
|
|
crypto.randomFillSync(buf);
|
|
const after = Buffer.from(buf.buffer).toString('hex');
|
|
assert.notStrictEqual(before, after);
|
|
});
|
|
}
|
|
|
|
{
|
|
const buf = Buffer.alloc(10);
|
|
const before = buf.toString('hex');
|
|
crypto.randomFill(buf, common.mustCall((err, buf) => {
|
|
assert.ifError(err);
|
|
const after = buf.toString('hex');
|
|
assert.notStrictEqual(before, after);
|
|
}));
|
|
}
|
|
|
|
{
|
|
const buf = new Uint8Array(new Array(10).fill(0));
|
|
const before = Buffer.from(buf).toString('hex');
|
|
crypto.randomFill(buf, common.mustCall((err, buf) => {
|
|
assert.ifError(err);
|
|
const after = Buffer.from(buf).toString('hex');
|
|
assert.notStrictEqual(before, after);
|
|
}));
|
|
}
|
|
|
|
{
|
|
[
|
|
new Uint16Array(10),
|
|
new Uint32Array(10),
|
|
new Float32Array(10),
|
|
new Float64Array(10),
|
|
new DataView(new ArrayBuffer(10))
|
|
].forEach((buf) => {
|
|
const before = Buffer.from(buf.buffer).toString('hex');
|
|
crypto.randomFill(buf, common.mustCall((err, buf) => {
|
|
assert.ifError(err);
|
|
const after = Buffer.from(buf.buffer).toString('hex');
|
|
assert.notStrictEqual(before, after);
|
|
}));
|
|
});
|
|
}
|
|
|
|
{
|
|
const buf = Buffer.alloc(10);
|
|
const before = buf.toString('hex');
|
|
crypto.randomFillSync(buf, 5, 5);
|
|
const after = buf.toString('hex');
|
|
assert.notStrictEqual(before, after);
|
|
assert.deepStrictEqual(before.slice(0, 5), after.slice(0, 5));
|
|
}
|
|
|
|
{
|
|
const buf = new Uint8Array(new Array(10).fill(0));
|
|
const before = Buffer.from(buf).toString('hex');
|
|
crypto.randomFillSync(buf, 5, 5);
|
|
const after = Buffer.from(buf).toString('hex');
|
|
assert.notStrictEqual(before, after);
|
|
assert.deepStrictEqual(before.slice(0, 5), after.slice(0, 5));
|
|
}
|
|
|
|
{
|
|
const buf = Buffer.alloc(10);
|
|
const before = buf.toString('hex');
|
|
crypto.randomFillSync(buf, 5);
|
|
const after = buf.toString('hex');
|
|
assert.notStrictEqual(before, after);
|
|
assert.deepStrictEqual(before.slice(0, 5), after.slice(0, 5));
|
|
}
|
|
|
|
{
|
|
const buf = Buffer.alloc(10);
|
|
const before = buf.toString('hex');
|
|
crypto.randomFill(buf, 5, 5, common.mustCall((err, buf) => {
|
|
assert.ifError(err);
|
|
const after = buf.toString('hex');
|
|
assert.notStrictEqual(before, after);
|
|
assert.deepStrictEqual(before.slice(0, 5), after.slice(0, 5));
|
|
}));
|
|
}
|
|
|
|
{
|
|
const buf = new Uint8Array(new Array(10).fill(0));
|
|
const before = Buffer.from(buf).toString('hex');
|
|
crypto.randomFill(buf, 5, 5, common.mustCall((err, buf) => {
|
|
assert.ifError(err);
|
|
const after = Buffer.from(buf).toString('hex');
|
|
assert.notStrictEqual(before, after);
|
|
assert.deepStrictEqual(before.slice(0, 5), after.slice(0, 5));
|
|
}));
|
|
}
|
|
|
|
{
|
|
[
|
|
Buffer.alloc(10),
|
|
new Uint8Array(new Array(10).fill(0))
|
|
].forEach((buf) => {
|
|
const len = Buffer.byteLength(buf);
|
|
assert.strictEqual(len, 10, `Expected byteLength of 10, got ${len}`);
|
|
|
|
const typeErrObj = {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "offset" argument must be of type number. ' +
|
|
"Received type string ('test')"
|
|
};
|
|
|
|
assert.throws(() => crypto.randomFillSync(buf, 'test'), typeErrObj);
|
|
|
|
assert.throws(
|
|
() => crypto.randomFill(buf, 'test', common.mustNotCall()),
|
|
typeErrObj);
|
|
|
|
typeErrObj.message = typeErrObj.message.replace('offset', 'size');
|
|
assert.throws(() => crypto.randomFillSync(buf, 0, 'test'), typeErrObj);
|
|
|
|
assert.throws(
|
|
() => crypto.randomFill(buf, 0, 'test', common.mustNotCall()),
|
|
typeErrObj
|
|
);
|
|
|
|
[NaN, kMaxPossibleLength + 1, -10, (-1 >>> 0) + 1].forEach((offsetSize) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "offset" is out of range. ' +
|
|
`It must be >= 0 && <= 10. Received ${offsetSize}`
|
|
};
|
|
|
|
assert.throws(() => crypto.randomFillSync(buf, offsetSize), errObj);
|
|
|
|
assert.throws(
|
|
() => crypto.randomFill(buf, offsetSize, common.mustNotCall()),
|
|
errObj);
|
|
|
|
errObj.message = 'The value of "size" is out of range. It must be >= ' +
|
|
`0 && <= ${kMaxPossibleLength}. Received ${offsetSize}`;
|
|
assert.throws(() => crypto.randomFillSync(buf, 1, offsetSize), errObj);
|
|
|
|
assert.throws(
|
|
() => crypto.randomFill(buf, 1, offsetSize, common.mustNotCall()),
|
|
errObj
|
|
);
|
|
});
|
|
|
|
const rangeErrObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "size + offset" is out of range. ' +
|
|
'It must be <= 10. Received 11'
|
|
};
|
|
assert.throws(() => crypto.randomFillSync(buf, 1, 10), rangeErrObj);
|
|
|
|
assert.throws(
|
|
() => crypto.randomFill(buf, 1, 10, common.mustNotCall()),
|
|
rangeErrObj
|
|
);
|
|
});
|
|
}
|
|
|
|
// https://github.com/nodejs/node-v0.x-archive/issues/5126,
|
|
// "FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() length
|
|
// exceeds max acceptable value"
|
|
assert.throws(
|
|
() => crypto.randomBytes((-1 >>> 0) + 1),
|
|
{
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "size" is out of range. ' +
|
|
`It must be >= 0 && <= ${kMaxPossibleLength}. Received 4294967296`
|
|
}
|
|
);
|
|
|
|
[1, true, NaN, null, undefined, {}, []].forEach((i) => {
|
|
const buf = Buffer.alloc(10);
|
|
assert.throws(
|
|
() => crypto.randomFillSync(i),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => crypto.randomFill(i, common.mustNotCall()),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError'
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => crypto.randomFill(buf, 0, 10, i),
|
|
{
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
name: 'TypeError',
|
|
message: `Callback must be a function. Received ${inspect(i)}`
|
|
});
|
|
});
|
|
|
|
[1, true, NaN, null, {}, []].forEach((i) => {
|
|
assert.throws(
|
|
() => crypto.randomBytes(1, i),
|
|
{
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
name: 'TypeError',
|
|
message: `Callback must be a function. Received ${inspect(i)}`
|
|
}
|
|
);
|
|
});
|
|
|
|
|
|
['pseudoRandomBytes', 'prng', 'rng'].forEach((f) => {
|
|
const desc = Object.getOwnPropertyDescriptor(crypto, f);
|
|
assert.ok(desc);
|
|
assert.strictEqual(desc.configurable, true);
|
|
assert.strictEqual(desc.writable, true);
|
|
assert.strictEqual(desc.enumerable, false);
|
|
});
|