mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
f399b01dc4
Before this commit, Node.js left it up to the system resolver or c-ares. Leaving it to the system resolver introduces platform differences because: * some support IDNA 2008 * some only IDNA 2003 (glibc until 2.28), and * some don't support IDNA at all (musl libc) c-ares doesn't support IDNA either although curl does, by virtue of linking against libidn2. Upgrading from libidn1 to libidn2 in order to get proper IDNA 2008 support was the fix for curl's CVE-2016-8625. libidn2 is not an option (incompatible license) but ICU has an IDNA API and we already use that in one place. For non-ICU builds, we fall back to the bundled punycode.js that also supports IDNA 2008. Fixes: https://github.com/nodejs-private/security/issues/97 Fixes: https://github.com/nodejs/node/issues/25558 PR-URL: https://github.com/nodejs/node/pull/25679 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> |
||
|---|---|---|
| .. | ||
| test-dgram-broadcast-multi-process.js | ||
| test-dgram-membership.js | ||
| test-dgram-multicast-multi-process.js | ||
| test-dgram-multicast-set-interface-lo.js | ||
| test-dgram-send-cb-quelches-error.js | ||
| test-dns-any.js | ||
| test-dns-cares-domains.js | ||
| test-dns-idna2008.js | ||
| test-dns-ipv4.js | ||
| test-dns-ipv6.js | ||
| test-dns-lookup.js | ||
| test-dns-promises-resolve.js | ||
| test-dns-regress-6244.js | ||
| test-dns-setserver-in-callback-of-resolve4.js | ||
| test-dns-txt-sigsegv.js | ||
| test-dns.js | ||
| test-http-dns-fail.js | ||
| test-http-https-default-ports.js | ||
| test-inspector-help-page.js | ||
| test-net-connect-timeout.js | ||
| test-net-connect-unref.js | ||
| test-tls-add-ca-cert.js | ||
| test-tls-connnect-melissadata.js | ||
| test-tls-reuse-host-from-socket.js | ||
| test-trace-events-dns.js | ||
| test-uv-threadpool-schedule.js | ||
| testcfg.py | ||