mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
aa6e9c80cf
While it was supposed to fix most of the remaining issues, https://github.com/nodejs/node/pull/46458 missed some in strict mode. This PR adds some additional checks. It also clarifies what we are really checking to execute or not the `GetReturnValue`. PR-URL: https://github.com/nodejs/node/pull/46615 Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
38 lines
1.1 KiB
JavaScript
38 lines
1.1 KiB
JavaScript
/* eslint-disable strict, no-var, no-delete-var, no-undef, node-core/required-modules, node-core/require-common-first */
|
|
// Importing common would break the execution. Indeed running `vm.runInThisContext` alters the global context
|
|
// when declaring new variables with `var`. The other rules (strict, no-var, no-delete-var) have been disabled
|
|
// in order to be able to test this specific not-strict case playing with `var` and `delete`.
|
|
// Related to bug report: https://github.com/nodejs/node/issues/43129
|
|
var assert = require('assert');
|
|
var vm = require('vm');
|
|
|
|
var data = [];
|
|
var a = 'direct';
|
|
delete a;
|
|
data.push(a);
|
|
|
|
var item2 = vm.runInThisContext(`
|
|
var unusedB = 1;
|
|
var data = [];
|
|
var b = "this";
|
|
delete b;
|
|
data.push(b);
|
|
data[0]
|
|
`);
|
|
data.push(item2);
|
|
|
|
vm.runInContext(
|
|
`
|
|
var unusedC = 1;
|
|
var c = "new";
|
|
delete c;
|
|
data.push(c);
|
|
`,
|
|
vm.createContext({ data: data })
|
|
);
|
|
|
|
assert.deepStrictEqual(data, ['direct', 'this', 'new']);
|
|
|
|
assert.strictEqual(typeof unusedB, 'number'); // Declared within runInThisContext
|
|
assert.strictEqual(typeof unusedC, 'undefined'); // Declared within runInContext
|