mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
f5ed3386fd
Emit process warning once per process when delay is a negative number or not a number, this will prevent unexpected behaviour caused by invalid `delay` also keep the consistency of the behaviour and warning message for `TIMEOUT_MAX` number As the negative number is invalid delay will be set to 1. PR-URL: https://github.com/nodejs/node/pull/46678 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
68 lines
1.5 KiB
JavaScript
68 lines
1.5 KiB
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const child_process = require('child_process');
|
|
const path = require('path');
|
|
|
|
const NEGATIVE_NUMBER = -1;
|
|
|
|
function timerNotCanceled() {
|
|
assert.fail('Timer should be canceled');
|
|
}
|
|
|
|
const testCases = ['timeout', 'interval', 'refresh'];
|
|
|
|
function runTests() {
|
|
const args = process.argv.slice(2);
|
|
|
|
const testChoice = args[0];
|
|
|
|
if (!testChoice) {
|
|
const filePath = path.join(__filename);
|
|
|
|
testCases.forEach((testCase) => {
|
|
const { stdout } = child_process.spawnSync(
|
|
process.execPath,
|
|
[filePath, testCase],
|
|
{ encoding: 'utf8' }
|
|
);
|
|
|
|
const lines = stdout.split('\n');
|
|
|
|
if (lines[0] === 'DeprecationWarning') return;
|
|
|
|
assert.strictEqual(lines[0], 'TimeoutNegativeWarning');
|
|
assert.strictEqual(lines[1], `${NEGATIVE_NUMBER} is a negative number.`);
|
|
assert.strictEqual(lines[2], 'Timeout duration was set to 1.');
|
|
});
|
|
}
|
|
|
|
if (args[0] === testCases[0]) {
|
|
const timeout = setTimeout(timerNotCanceled, NEGATIVE_NUMBER);
|
|
clearTimeout(timeout);
|
|
}
|
|
|
|
if (args[0] === testCases[1]) {
|
|
const interval = setInterval(timerNotCanceled, NEGATIVE_NUMBER);
|
|
clearInterval(interval);
|
|
}
|
|
|
|
if (args[0] === testCases[2]) {
|
|
const timeout = setTimeout(timerNotCanceled, NEGATIVE_NUMBER);
|
|
timeout.refresh();
|
|
clearTimeout(timeout);
|
|
}
|
|
|
|
process.on(
|
|
'warning',
|
|
|
|
(warning) => {
|
|
console.log(warning.name);
|
|
console.log(warning.message);
|
|
}
|
|
);
|
|
}
|
|
|
|
runTests();
|