mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
2b32985c62
When no error occurs, use `null` instead of `undefined` for the `error` argument of the `writable.write()` and `writable.end()` callbacks. Fixes: https://github.com/nodejs/node/issues/44290 PR-URL: https://github.com/nodejs/node/pull/44312 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
79 lines
2.0 KiB
JavaScript
79 lines
2.0 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const stream = require('stream');
|
|
|
|
{
|
|
// Invoke end callback on failure.
|
|
const writable = new stream.Writable();
|
|
|
|
const _err = new Error('kaboom');
|
|
writable._write = (chunk, encoding, cb) => {
|
|
process.nextTick(cb, _err);
|
|
};
|
|
|
|
writable.on('error', common.mustCall((err) => {
|
|
assert.strictEqual(err, _err);
|
|
}));
|
|
writable.write('asd');
|
|
writable.end(common.mustCall((err) => {
|
|
assert.strictEqual(err, _err);
|
|
}));
|
|
writable.end(common.mustCall((err) => {
|
|
assert.strictEqual(err, _err);
|
|
}));
|
|
}
|
|
|
|
{
|
|
// Don't invoke end callback twice
|
|
const writable = new stream.Writable();
|
|
|
|
writable._write = (chunk, encoding, cb) => {
|
|
process.nextTick(cb);
|
|
};
|
|
|
|
let called = false;
|
|
writable.end('asd', common.mustCall((err) => {
|
|
called = true;
|
|
assert.strictEqual(err, null);
|
|
}));
|
|
|
|
writable.on('error', common.mustCall((err) => {
|
|
assert.strictEqual(err.message, 'kaboom');
|
|
}));
|
|
writable.on('finish', common.mustCall(() => {
|
|
assert.strictEqual(called, true);
|
|
writable.emit('error', new Error('kaboom'));
|
|
}));
|
|
}
|
|
|
|
{
|
|
const w = new stream.Writable({
|
|
write(chunk, encoding, callback) {
|
|
setImmediate(callback);
|
|
},
|
|
finish(callback) {
|
|
setImmediate(callback);
|
|
}
|
|
});
|
|
w.end('testing ended state', common.mustCall((err) => {
|
|
assert.strictEqual(err.code, 'ERR_STREAM_WRITE_AFTER_END');
|
|
}));
|
|
assert.strictEqual(w.destroyed, false);
|
|
assert.strictEqual(w.writableEnded, true);
|
|
w.end(common.mustCall((err) => {
|
|
assert.strictEqual(err.code, 'ERR_STREAM_WRITE_AFTER_END');
|
|
}));
|
|
assert.strictEqual(w.destroyed, false);
|
|
assert.strictEqual(w.writableEnded, true);
|
|
w.end('end', common.mustCall((err) => {
|
|
assert.strictEqual(err.code, 'ERR_STREAM_WRITE_AFTER_END');
|
|
}));
|
|
assert.strictEqual(w.destroyed, true);
|
|
w.on('error', common.mustCall((err) => {
|
|
assert.strictEqual(err.code, 'ERR_STREAM_WRITE_AFTER_END');
|
|
}));
|
|
w.on('finish', common.mustNotCall());
|
|
}
|