mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
78150f3e9c
WebStream's Readable controller does not tolerate `.close()` being called after an `error`. However, when wrapping a Node's Readable stream it is possible that the sequence of events leads to `finished()`'s callback being invoked after such `error`. In order to handle this, in this change we call the `finished()` handler earlier when controller is canceled, and always handle this as an error case. Fix: https://github.com/nodejs/node/issues/54205 PR-URL: https://github.com/nodejs/node/pull/54206 Fixes: https://github.com/nodejs/node/issues/54205 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
13 lines
292 B
JavaScript
13 lines
292 B
JavaScript
'use strict';
|
|
require('../common');
|
|
const { Readable } = require('stream');
|
|
|
|
{
|
|
const r = Readable.from([]);
|
|
// Cancelling reader while closing should not cause uncaught exceptions
|
|
r.on('close', () => reader.cancel());
|
|
|
|
const reader = Readable.toWeb(r).getReader();
|
|
reader.read();
|
|
}
|