0
0
mirror of https://github.com/nodejs/node.git synced 2024-11-24 20:29:23 +01:00
nodejs/test/parallel/test-stream-readable-setEncoding-existing-buffers.js
Anna Henningsen afb84744c6 stream: convert existing buffer when calling .setEncoding
Convert already-stored chunks when `.setEncoding()` is called
so that subsequent `data` events will receive decoded strings,
as they expect.

Fixes: https://github.com/nodejs/node/issues/27932

PR-URL: https://github.com/nodejs/node/pull/27936
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2019-05-30 14:35:29 +02:00

61 lines
1.3 KiB
JavaScript

'use strict';
require('../common');
const { Readable } = require('stream');
const assert = require('assert');
{
// Call .setEncoding() while there are bytes already in the buffer.
const r = new Readable({ read() {} });
r.push(Buffer.from('a'));
r.push(Buffer.from('b'));
r.setEncoding('utf8');
const chunks = [];
r.on('data', (chunk) => chunks.push(chunk));
process.nextTick(() => {
assert.deepStrictEqual(chunks, ['ab']);
});
}
{
// Call .setEncoding() while the buffer contains a complete,
// but chunked character.
const r = new Readable({ read() {} });
r.push(Buffer.from([0xf0]));
r.push(Buffer.from([0x9f]));
r.push(Buffer.from([0x8e]));
r.push(Buffer.from([0x89]));
r.setEncoding('utf8');
const chunks = [];
r.on('data', (chunk) => chunks.push(chunk));
process.nextTick(() => {
assert.deepStrictEqual(chunks, ['🎉']);
});
}
{
// Call .setEncoding() while the buffer contains an incomplete character,
// and finish the character later.
const r = new Readable({ read() {} });
r.push(Buffer.from([0xf0]));
r.push(Buffer.from([0x9f]));
r.setEncoding('utf8');
r.push(Buffer.from([0x8e]));
r.push(Buffer.from([0x89]));
const chunks = [];
r.on('data', (chunk) => chunks.push(chunk));
process.nextTick(() => {
assert.deepStrictEqual(chunks, ['🎉']);
});
}