mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
1fcb128771
We had a bunch of tests that would fail if run from an executable that contains any char that should be escaped when run from a shell. PR-URL: https://github.com/nodejs/node/pull/55028 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
52 lines
1.6 KiB
JavaScript
52 lines
1.6 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const process = require('process');
|
|
|
|
let defaultShell;
|
|
if (process.platform === 'linux' || process.platform === 'darwin') {
|
|
defaultShell = '/bin/sh';
|
|
} else if (process.platform === 'win32') {
|
|
defaultShell = 'cmd.exe';
|
|
} else {
|
|
common.skip('This is test exists only on Linux/Win32/macOS');
|
|
}
|
|
|
|
const { execSync } = require('child_process');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
const tmpDir = tmpdir.path;
|
|
tmpdir.refresh();
|
|
const tmpCmdFile = path.join(tmpDir, 'test-stdin-from-file-spawn-cmd');
|
|
const tmpJsFile = path.join(tmpDir, 'test-stdin-from-file-spawn.js');
|
|
fs.writeFileSync(tmpCmdFile, 'echo hello');
|
|
fs.writeFileSync(tmpJsFile, `
|
|
'use strict';
|
|
const { spawn } = require('child_process');
|
|
// Reference the object to invoke the getter
|
|
process.stdin;
|
|
setTimeout(() => {
|
|
let ok = false;
|
|
const child = spawn(process.env.SHELL || '${defaultShell}',
|
|
[], { stdio: ['inherit', 'pipe'] });
|
|
child.stdout.on('data', () => {
|
|
ok = true;
|
|
});
|
|
child.on('close', () => {
|
|
process.exit(ok ? 0 : -1);
|
|
});
|
|
}, 100);
|
|
`);
|
|
|
|
// The execPath might contain chars that should be escaped in a shell context.
|
|
// On non-Windows, we can pass the path via the env; `"` is not a valid char on
|
|
// Windows, so we can simply pass the path.
|
|
execSync(
|
|
`"${common.isWindows ? process.execPath : '$NODE'}" "${
|
|
common.isWindows ? tmpJsFile : '$FILE'}" < "${common.isWindows ? tmpCmdFile : '$CMD_FILE'}"`,
|
|
common.isWindows ? undefined : {
|
|
env: { ...process.env, NODE: process.execPath, FILE: tmpJsFile, CMD_FILE: tmpCmdFile },
|
|
},
|
|
);
|