mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
330f25ef82
Make changes so that tests will pass when the comma-dangle settings applied to the rest of the code base are also applied to tests. PR-URL: https://github.com/nodejs/node/pull/37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
82 lines
2.1 KiB
JavaScript
82 lines
2.1 KiB
JavaScript
'use strict';
|
|
|
|
// Flags: --expose-internals
|
|
|
|
const common = require('../common');
|
|
const stream = require('stream');
|
|
const repl = require('internal/repl');
|
|
const assert = require('assert');
|
|
|
|
// Array of [useGlobal, expectedResult] pairs
|
|
const globalTestCases = [
|
|
[false, 'undefined'],
|
|
[true, '\'tacos\''],
|
|
[undefined, 'undefined'],
|
|
];
|
|
|
|
const globalTest = (useGlobal, cb, output) => (err, repl) => {
|
|
if (err)
|
|
return cb(err);
|
|
|
|
let str = '';
|
|
output.on('data', (data) => (str += data));
|
|
global.lunch = 'tacos';
|
|
repl.write('global.lunch;\n');
|
|
repl.close();
|
|
delete global.lunch;
|
|
cb(null, str.trim());
|
|
};
|
|
|
|
// Test how the global object behaves in each state for useGlobal
|
|
for (const [option, expected] of globalTestCases) {
|
|
runRepl(option, globalTest, common.mustSucceed((output) => {
|
|
assert.strictEqual(output, expected);
|
|
}));
|
|
}
|
|
|
|
// Test how shadowing the process object via `let`
|
|
// behaves in each useGlobal state. Note: we can't
|
|
// actually test the state when useGlobal is true,
|
|
// because the exception that's generated is caught
|
|
// (see below), but errors are printed, and the test
|
|
// suite is aware of it, causing a failure to be flagged.
|
|
//
|
|
const processTestCases = [false, undefined];
|
|
const processTest = (useGlobal, cb, output) => (err, repl) => {
|
|
if (err)
|
|
return cb(err);
|
|
|
|
let str = '';
|
|
output.on('data', (data) => (str += data));
|
|
|
|
// If useGlobal is false, then `let process` should work
|
|
repl.write('let process;\n');
|
|
repl.write('21 * 2;\n');
|
|
repl.close();
|
|
cb(null, str.trim());
|
|
};
|
|
|
|
for (const option of processTestCases) {
|
|
runRepl(option, processTest, common.mustSucceed((output) => {
|
|
assert.strictEqual(output, 'undefined\n42');
|
|
}));
|
|
}
|
|
|
|
function runRepl(useGlobal, testFunc, cb) {
|
|
const inputStream = new stream.PassThrough();
|
|
const outputStream = new stream.PassThrough();
|
|
const opts = {
|
|
input: inputStream,
|
|
output: outputStream,
|
|
useGlobal: useGlobal,
|
|
useColors: false,
|
|
terminal: false,
|
|
prompt: ''
|
|
};
|
|
|
|
repl.createInternalRepl(
|
|
process.env,
|
|
opts,
|
|
testFunc(useGlobal, cb, opts.output));
|
|
}
|