mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
6a22b77bba
There is a race condition where process.kill can be sent before the target is ready to receive the signal. Fixes: https://github.com/nodejs/node/issues/41123 PR-URL: https://github.com/nodejs/node/pull/45354 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
50 lines
1.3 KiB
JavaScript
50 lines
1.3 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
if (common.isWindows) {
|
|
// No way to send CTRL_C_EVENT to processes from JS right now.
|
|
common.skip('platform not supported');
|
|
}
|
|
if (!common.isMainThread)
|
|
common.skip('No signal handling available in Workers');
|
|
|
|
const assert = require('assert');
|
|
const spawn = require('child_process').spawn;
|
|
|
|
const child = spawn(process.execPath, [ '-i' ], {
|
|
stdio: [null, null, 2, 'ipc']
|
|
});
|
|
|
|
let stdout = '';
|
|
child.stdout.setEncoding('utf8');
|
|
child.stdout.on('data', function(c) {
|
|
stdout += c;
|
|
});
|
|
|
|
child.stdout.once('data', common.mustCall(() => {
|
|
child.on('message', common.mustCall((msg) => {
|
|
assert.strictEqual(msg, 'repl is busy');
|
|
process.kill(child.pid, 'SIGINT');
|
|
child.stdout.once('data', common.mustCall(() => {
|
|
// Make sure REPL still works.
|
|
child.stdin.end('"foobar"\n');
|
|
}));
|
|
}));
|
|
|
|
child.stdin.write(
|
|
'vm.runInThisContext("process.send(\'repl is busy\'); while(true){}", ' +
|
|
'{ breakOnSigint: true });\n'
|
|
);
|
|
}));
|
|
|
|
child.on('close', function(code) {
|
|
const expected = 'Script execution was interrupted by `SIGINT`';
|
|
assert.ok(
|
|
stdout.includes(expected),
|
|
`Expected stdout to contain "${expected}", got ${stdout}`
|
|
);
|
|
assert.ok(
|
|
stdout.includes('foobar'),
|
|
`Expected stdout to contain "foobar", got ${stdout}`
|
|
);
|
|
});
|