mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
2cc6a0c545
The second parameter of `Error.prepareStackTrace` is an array of reversed call site frames. PR-URL: https://github.com/nodejs/node/pull/50827 Fixes: https://github.com/nodejs/node/issues/50733 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
89 lines
2.2 KiB
JavaScript
89 lines
2.2 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const ArrayStream = require('../common/arraystream');
|
|
const fixtures = require('../common/fixtures');
|
|
const assert = require('assert');
|
|
const repl = require('repl');
|
|
|
|
const stackRegExp = /(REPL\d+):[0-9]+:[0-9]+/g;
|
|
|
|
function run({ command, expected }) {
|
|
let accum = '';
|
|
|
|
const inputStream = new ArrayStream();
|
|
const outputStream = new ArrayStream();
|
|
|
|
outputStream.write = (data) => accum += data.replace('\r', '');
|
|
|
|
const r = repl.start({
|
|
prompt: '',
|
|
input: inputStream,
|
|
output: outputStream,
|
|
terminal: false,
|
|
useColors: false
|
|
});
|
|
|
|
r.write(`${command}\n`);
|
|
if (typeof expected === 'string') {
|
|
assert.strictEqual(
|
|
accum.replace(stackRegExp, '$1:*:*'),
|
|
expected.replace(stackRegExp, '$1:*:*')
|
|
);
|
|
} else {
|
|
assert.match(
|
|
accum.replace(stackRegExp, '$1:*:*'),
|
|
expected
|
|
);
|
|
}
|
|
r.close();
|
|
}
|
|
|
|
const origPrepareStackTrace = Error.prepareStackTrace;
|
|
Error.prepareStackTrace = (err, stack) => {
|
|
if (err instanceof SyntaxError)
|
|
return err.toString();
|
|
// Insert the error at the beginning of the stack
|
|
stack.unshift(err);
|
|
return stack.join('--->\n');
|
|
};
|
|
|
|
process.on('uncaughtException', (e) => {
|
|
Error.prepareStackTrace = origPrepareStackTrace;
|
|
throw e;
|
|
});
|
|
|
|
const tests = [
|
|
{
|
|
// test .load for a file that throws
|
|
command: `.load ${fixtures.path('repl-pretty-stack.js')}`,
|
|
expected: 'Uncaught Error: Whoops!--->\nREPL1:*:*--->\nd (REPL1:*:*)' +
|
|
'--->\nc (REPL1:*:*)--->\nb (REPL1:*:*)--->\na (REPL1:*:*)\n'
|
|
},
|
|
{
|
|
command: 'let x y;',
|
|
expected: /let x y;\n {6}\^\n\nUncaught SyntaxError: Unexpected identifier.*\n/
|
|
},
|
|
{
|
|
command: 'throw new Error(\'Whoops!\')',
|
|
expected: 'Uncaught Error: Whoops!\n'
|
|
},
|
|
{
|
|
command: 'foo = bar;',
|
|
expected: 'Uncaught ReferenceError: bar is not defined\n'
|
|
},
|
|
// test anonymous IIFE
|
|
{
|
|
command: '(function() { throw new Error(\'Whoops!\'); })()',
|
|
expected: 'Uncaught Error: Whoops!--->\nREPL5:*:*\n'
|
|
},
|
|
];
|
|
|
|
tests.forEach(run);
|
|
|
|
// Verify that the stack can be generated when Error.prepareStackTrace is deleted.
|
|
delete Error.prepareStackTrace;
|
|
run({
|
|
command: 'throw new TypeError(\'Whoops!\')',
|
|
expected: 'Uncaught TypeError: Whoops!\n'
|
|
});
|