0
0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 21:19:50 +01:00
nodejs/test/parallel/test-readable-from-iterator-closing.js
Pranshu Srivastava 2cd79700c0 stream: add null check in Readable.from
Throws `ERR_STREAM_NULL_VALUES` error if a null value is passed to
`Readable.from`. Also added docs for the same.

Co-Authored-By: 扩散性百万甜面包 <himself65@outlook.com>
Fixes: https://github.com/nodejs/node/issues/32845
PR-URL: https://github.com/nodejs/node/pull/32873
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2020-04-29 09:41:31 +02:00

198 lines
3.9 KiB
JavaScript

'use strict';
const { mustCall, mustNotCall } = require('../common');
const { Readable } = require('stream');
const { strictEqual } = require('assert');
async function asyncSupport() {
const finallyMustCall = mustCall();
const bodyMustCall = mustCall();
async function* infiniteGenerate() {
try {
while (true) yield 'a';
} finally {
finallyMustCall();
}
}
const stream = Readable.from(infiniteGenerate());
for await (const chunk of stream) {
bodyMustCall();
strictEqual(chunk, 'a');
break;
}
}
async function syncSupport() {
const finallyMustCall = mustCall();
const bodyMustCall = mustCall();
function* infiniteGenerate() {
try {
while (true) yield 'a';
} finally {
finallyMustCall();
}
}
const stream = Readable.from(infiniteGenerate());
for await (const chunk of stream) {
bodyMustCall();
strictEqual(chunk, 'a');
break;
}
}
async function syncPromiseSupport() {
const returnMustBeAwaited = mustCall();
const bodyMustCall = mustCall();
function* infiniteGenerate() {
try {
while (true) yield Promise.resolve('a');
} finally {
// eslint-disable-next-line no-unsafe-finally
return { then(cb) {
returnMustBeAwaited();
cb();
} };
}
}
const stream = Readable.from(infiniteGenerate());
for await (const chunk of stream) {
bodyMustCall();
strictEqual(chunk, 'a');
break;
}
}
async function syncRejectedSupport() {
const returnMustBeAwaited = mustCall();
const bodyMustNotCall = mustNotCall();
const catchMustCall = mustCall();
const secondNextMustNotCall = mustNotCall();
function* generate() {
try {
yield Promise.reject('a');
secondNextMustNotCall();
} finally {
// eslint-disable-next-line no-unsafe-finally
return { then(cb) {
returnMustBeAwaited();
cb();
} };
}
}
const stream = Readable.from(generate());
try {
for await (const chunk of stream) {
bodyMustNotCall(chunk);
}
} catch {
catchMustCall();
}
}
async function noReturnAfterThrow() {
const returnMustNotCall = mustNotCall();
const bodyMustNotCall = mustNotCall();
const catchMustCall = mustCall();
const nextMustCall = mustCall();
const stream = Readable.from({
[Symbol.asyncIterator]() { return this; },
async next() {
nextMustCall();
throw new Error('a');
},
async return() {
returnMustNotCall();
return { done: true };
},
});
try {
for await (const chunk of stream) {
bodyMustNotCall(chunk);
}
} catch {
catchMustCall();
}
}
async function closeStreamWhileNextIsPending() {
const finallyMustCall = mustCall();
const dataMustCall = mustCall();
let resolveDestroy;
const destroyed =
new Promise((resolve) => { resolveDestroy = mustCall(resolve); });
let resolveYielded;
const yielded =
new Promise((resolve) => { resolveYielded = mustCall(resolve); });
async function* infiniteGenerate() {
try {
while (true) {
yield 'a';
resolveYielded();
await destroyed;
}
} finally {
finallyMustCall();
}
}
const stream = Readable.from(infiniteGenerate());
stream.on('data', (data) => {
dataMustCall();
strictEqual(data, 'a');
});
yielded.then(() => {
stream.destroy();
resolveDestroy();
});
}
async function closeAfterNullYielded() {
const finallyMustCall = mustCall();
const dataMustCall = mustCall(3);
function* generate() {
try {
yield 'a';
yield 'a';
yield 'a';
} finally {
finallyMustCall();
}
}
const stream = Readable.from(generate());
stream.on('data', (chunk) => {
dataMustCall();
strictEqual(chunk, 'a');
});
}
Promise.all([
asyncSupport(),
syncSupport(),
syncPromiseSupport(),
syncRejectedSupport(),
noReturnAfterThrow(),
closeStreamWhileNextIsPending(),
closeAfterNullYielded(),
]).then(mustCall());