mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
3a0968db43
This improves Permission Model usage when allowing read access to specifi modules. To achieve that, the permission model check on internalModuleStat has been removed meaning that on module loading, uv_fs_stat is performed on files and folders even when the permission model is enabled. Although a uv_fs_stat is performed, reading/executing the module will still pass by the permission model check. Without this PR when an app tries to --allow-fs-read=./a.js --allow-fs-read=./b.js where `a` attempt to load b, it will fails as it reads $pwd and no permission has been given to this path. PR-URL: https://github.com/nodejs/node/pull/55797 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
77 lines
2.1 KiB
JavaScript
77 lines
2.1 KiB
JavaScript
// Flags: --experimental-permission --allow-fs-read=* --allow-child-process
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
common.skipIfWorker();
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const assert = require('node:assert');
|
|
const { spawnSync } = require('node:child_process');
|
|
|
|
{
|
|
const mainModule = fixtures.path('permission', 'main-module.js');
|
|
const requiredModule = fixtures.path('permission', 'required-module.js');
|
|
const { status, stdout, stderr } = spawnSync(
|
|
process.execPath,
|
|
[
|
|
'--experimental-permission',
|
|
'--allow-fs-read', mainModule,
|
|
'--allow-fs-read', requiredModule,
|
|
mainModule,
|
|
]
|
|
);
|
|
|
|
assert.strictEqual(status, 0, stderr.toString());
|
|
assert.strictEqual(stdout.toString(), 'ok\n');
|
|
}
|
|
|
|
{
|
|
// When required module is not passed as allowed path
|
|
const mainModule = fixtures.path('permission', 'main-module.js');
|
|
const { status, stderr } = spawnSync(
|
|
process.execPath,
|
|
[
|
|
'--experimental-permission',
|
|
'--allow-fs-read', mainModule,
|
|
mainModule,
|
|
]
|
|
);
|
|
|
|
assert.strictEqual(status, 1, stderr.toString());
|
|
assert.match(stderr.toString(), /Error: Access to this API has been restricted/);
|
|
}
|
|
|
|
{
|
|
// ESM loader test
|
|
const mainModule = fixtures.path('permission', 'main-module.mjs');
|
|
const requiredModule = fixtures.path('permission', 'required-module.mjs');
|
|
const { status, stdout, stderr } = spawnSync(
|
|
process.execPath,
|
|
[
|
|
'--experimental-permission',
|
|
'--allow-fs-read', mainModule,
|
|
'--allow-fs-read', requiredModule,
|
|
mainModule,
|
|
]
|
|
);
|
|
|
|
assert.strictEqual(status, 0, stderr.toString());
|
|
assert.strictEqual(stdout.toString(), 'ok\n');
|
|
}
|
|
|
|
{
|
|
// When required module is not passed as allowed path (ESM)
|
|
const mainModule = fixtures.path('permission', 'main-module.mjs');
|
|
const { status, stderr } = spawnSync(
|
|
process.execPath,
|
|
[
|
|
'--experimental-permission',
|
|
'--allow-fs-read', mainModule,
|
|
mainModule,
|
|
]
|
|
);
|
|
|
|
assert.strictEqual(status, 1, stderr.toString());
|
|
assert.match(stderr.toString(), /Error: Access to this API has been restricted/);
|
|
}
|