mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
78ca61e2cf
Previously Node.js would handle empty `net.connect()` and `socket.connect()` call as if the user passed empty options object which doesn't really make sense. This was due to the fact that it uses the same `normalizeArgs` function as `.listen()` call where such call is perfectly fine. This will make it clear what is the problem with such call and how it can be resolved. It now throws `ERR_MISSING_ARGS` if no arguments were passed or neither `path` nor `port` is specified. Fixes: https://github.com/nodejs/node/issues/33930 PR-URL: https://github.com/nodejs/node/pull/34022 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
36 lines
816 B
JavaScript
36 lines
816 B
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const net = require('net');
|
|
|
|
// Tests that net.connect() called without arguments throws ERR_MISSING_ARGS.
|
|
|
|
assert.throws(() => {
|
|
net.connect();
|
|
}, {
|
|
code: 'ERR_MISSING_ARGS',
|
|
message: 'The "options" or "port" or "path" argument must be specified',
|
|
});
|
|
|
|
assert.throws(() => {
|
|
new net.Socket().connect();
|
|
}, {
|
|
code: 'ERR_MISSING_ARGS',
|
|
message: 'The "options" or "port" or "path" argument must be specified',
|
|
});
|
|
|
|
assert.throws(() => {
|
|
net.connect({});
|
|
}, {
|
|
code: 'ERR_MISSING_ARGS',
|
|
message: 'The "options" or "port" or "path" argument must be specified',
|
|
});
|
|
|
|
assert.throws(() => {
|
|
new net.Socket().connect({});
|
|
}, {
|
|
code: 'ERR_MISSING_ARGS',
|
|
message: 'The "options" or "port" or "path" argument must be specified',
|
|
});
|