mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
2ccf15b2bf
Adds a test to ensure that 'finish' is emitted
before the socket is destroyed by allow half-open
enforcer.
Refs: 3c07b1793c (commitcomment-38810268)
PR-URL: https://github.com/nodejs/node/pull/33137
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
48 lines
1.3 KiB
JavaScript
48 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const net = require('net');
|
|
|
|
{
|
|
const server = net.createServer(common.mustCall((socket) => {
|
|
socket.end(Buffer.alloc(1024));
|
|
})).listen(0, common.mustCall(() => {
|
|
const socket = net.connect(server.address().port);
|
|
assert.strictEqual(socket.allowHalfOpen, false);
|
|
socket.resume();
|
|
socket.on('end', common.mustCall(() => {
|
|
process.nextTick(() => {
|
|
// Ensure socket is not destroyed straight away
|
|
// without proper shutdown.
|
|
assert(!socket.destroyed);
|
|
server.close();
|
|
});
|
|
}));
|
|
socket.on('finish', common.mustCall(() => {
|
|
assert(!socket.destroyed);
|
|
}));
|
|
socket.on('close', common.mustCall());
|
|
}));
|
|
}
|
|
|
|
{
|
|
const server = net.createServer(common.mustCall((socket) => {
|
|
socket.end(Buffer.alloc(1024));
|
|
})).listen(0, common.mustCall(() => {
|
|
const socket = net.connect(server.address().port);
|
|
assert.strictEqual(socket.allowHalfOpen, false);
|
|
socket.resume();
|
|
socket.on('end', common.mustCall(() => {
|
|
assert(!socket.destroyed);
|
|
}));
|
|
socket.end('asd');
|
|
socket.on('finish', common.mustCall(() => {
|
|
assert(!socket.destroyed);
|
|
}));
|
|
socket.on('close', common.mustCall(() => {
|
|
server.close();
|
|
}));
|
|
}));
|
|
}
|