mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
bd7a8087a5
The connection interval should close when httpsServer.close is called similarly to how it gets cleared when httpServer.close is called. fixes: https://github.com/nodejs/node/issues/48373 PR-URL: https://github.com/nodejs/node/pull/48383 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
73 lines
1.8 KiB
JavaScript
73 lines
1.8 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const { createServer } = require('http');
|
|
const { connect } = require('net');
|
|
|
|
let connections = 0;
|
|
|
|
const server = createServer(common.mustCall(function(req, res) {
|
|
res.writeHead(200, { Connection: 'keep-alive' });
|
|
res.end();
|
|
}), {
|
|
headersTimeout: 0,
|
|
keepAliveTimeout: 0,
|
|
requestTimeout: common.platformTimeout(60000),
|
|
});
|
|
|
|
server.on('connection', function() {
|
|
connections++;
|
|
});
|
|
|
|
server.listen(0, function() {
|
|
const port = server.address().port;
|
|
let client1Closed = false;
|
|
let client2Closed = false;
|
|
|
|
// Create a first request but never finish it
|
|
const client1 = connect(port);
|
|
|
|
client1.on('connect', common.mustCall(() => {
|
|
// Create a second request, let it finish but leave the connection opened using HTTP keep-alive
|
|
const client2 = connect(port);
|
|
let response = '';
|
|
|
|
client2.setEncoding('utf8');
|
|
|
|
client2.on('data', common.mustCall((chunk) => {
|
|
response += chunk;
|
|
|
|
if (response.endsWith('0\r\n\r\n')) {
|
|
assert(response.startsWith('HTTP/1.1 200 OK\r\nConnection: keep-alive'));
|
|
assert.strictEqual(connections, 2);
|
|
|
|
server.close(common.mustCall());
|
|
|
|
// Check that only the idle connection got closed
|
|
setTimeout(common.mustCall(() => {
|
|
assert(!client1Closed);
|
|
assert(client2Closed);
|
|
|
|
server.closeAllConnections();
|
|
server.close(common.mustCall());
|
|
}), common.platformTimeout(500)).unref();
|
|
}
|
|
}));
|
|
|
|
client2.on('close', common.mustCall(() => {
|
|
client2Closed = true;
|
|
}));
|
|
|
|
client2.write('GET / HTTP/1.1\r\nHost: example.com\r\n\r\n');
|
|
}));
|
|
|
|
client1.on('close', common.mustCall(() => {
|
|
client1Closed = true;
|
|
}));
|
|
|
|
client1.on('error', () => {});
|
|
|
|
client1.write('GET / HTTP/1.1');
|
|
});
|