mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
651c02cbbc
Null the `joinDuplicateHeaders` property when the parser is freed. Refs: https://github.com/nodejs/node/pull/45982 PR-URL: https://github.com/nodejs/node/pull/48608 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
49 lines
1.3 KiB
JavaScript
49 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
const { HTTPParser } = require('_http_common');
|
|
|
|
// Test that the `HTTPParser` instance is cleaned up before being returned to
|
|
// the pool to avoid memory retention issues.
|
|
|
|
const kOnTimeout = HTTPParser.kOnTimeout | 0;
|
|
const server = http.createServer();
|
|
|
|
server.on('request', common.mustCall((request, response) => {
|
|
const parser = request.socket.parser;
|
|
|
|
assert.strictEqual(typeof parser[kOnTimeout], 'function');
|
|
|
|
request.socket.on('close', common.mustCall(() => {
|
|
assert.strictEqual(parser[kOnTimeout], null);
|
|
}));
|
|
|
|
response.end();
|
|
server.close();
|
|
}));
|
|
|
|
server.listen(common.mustCall(() => {
|
|
const request = http.get({
|
|
headers: { Connection: 'close' },
|
|
port: server.address().port,
|
|
joinDuplicateHeaders: true
|
|
});
|
|
let parser;
|
|
|
|
request.on('socket', common.mustCall(() => {
|
|
parser = request.parser;
|
|
assert.strictEqual(typeof parser.onIncoming, 'function');
|
|
assert.strictEqual(parser.joinDuplicateHeaders, true);
|
|
}));
|
|
|
|
request.on('response', common.mustCall((response) => {
|
|
response.resume();
|
|
response.on('end', common.mustCall(() => {
|
|
assert.strictEqual(parser.onIncoming, null);
|
|
assert.strictEqual(parser.joinDuplicateHeaders, null);
|
|
}));
|
|
}));
|
|
}));
|