mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
711e210d35
Fix an issue where AbortSignals are registered twice PR-URL: https://github.com/nodejs/node/pull/37730 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
74 lines
2.1 KiB
JavaScript
74 lines
2.1 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
const Agent = http.Agent;
|
|
const { getEventListeners, once } = require('events');
|
|
const agent = new Agent();
|
|
const server = http.createServer();
|
|
|
|
server.listen(0, common.mustCall(async () => {
|
|
const port = server.address().port;
|
|
const host = 'localhost';
|
|
const options = {
|
|
port: port,
|
|
host: host,
|
|
_agentKey: agent.getName({ port, host })
|
|
};
|
|
|
|
async function postCreateConnection() {
|
|
const ac = new AbortController();
|
|
const { signal } = ac;
|
|
const connection = agent.createConnection({ ...options, signal });
|
|
assert.strictEqual(getEventListeners(signal, 'abort').length, 1);
|
|
ac.abort();
|
|
const [err] = await once(connection, 'error');
|
|
assert.strictEqual(err?.name, 'AbortError');
|
|
}
|
|
|
|
async function preCreateConnection() {
|
|
const ac = new AbortController();
|
|
const { signal } = ac;
|
|
ac.abort();
|
|
const connection = agent.createConnection({ ...options, signal });
|
|
const [err] = await once(connection, 'error');
|
|
assert.strictEqual(err?.name, 'AbortError');
|
|
}
|
|
|
|
async function agentAsParam() {
|
|
const ac = new AbortController();
|
|
const { signal } = ac;
|
|
const request = http.get({
|
|
port: server.address().port,
|
|
path: '/hello',
|
|
agent: agent,
|
|
signal,
|
|
});
|
|
assert.strictEqual(getEventListeners(signal, 'abort').length, 1);
|
|
ac.abort();
|
|
const [err] = await once(request, 'error');
|
|
assert.strictEqual(err?.name, 'AbortError');
|
|
}
|
|
|
|
async function agentAsParamPreAbort() {
|
|
const ac = new AbortController();
|
|
const { signal } = ac;
|
|
ac.abort();
|
|
const request = http.get({
|
|
port: server.address().port,
|
|
path: '/hello',
|
|
agent: agent,
|
|
signal,
|
|
});
|
|
assert.strictEqual(getEventListeners(signal, 'abort').length, 0);
|
|
const [err] = await once(request, 'error');
|
|
assert.strictEqual(err?.name, 'AbortError');
|
|
}
|
|
|
|
await postCreateConnection();
|
|
await preCreateConnection();
|
|
await agentAsParam();
|
|
await agentAsParamPreAbort();
|
|
server.close();
|
|
}));
|