mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
9edce1e12a
This updates a lot of comments. PR-URL: https://github.com/nodejs/node/pull/26223 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
38 lines
1.1 KiB
JavaScript
38 lines
1.1 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
|
|
// This test ensures that `addRequest`'s Legacy API accepts `localAddress`
|
|
// correctly instead of accepting `path`.
|
|
// https://github.com/nodejs/node/issues/5051
|
|
|
|
const assert = require('assert');
|
|
const agent = require('http').globalAgent;
|
|
|
|
// Small stub just so we can call addRequest directly
|
|
const req = {
|
|
getHeader: () => {}
|
|
};
|
|
|
|
agent.maxSockets = 0;
|
|
|
|
// `localAddress` is used when naming requests / sockets while using the Legacy
|
|
// API. Port 8080 is hardcoded since this does not create a network connection.
|
|
agent.addRequest(req, 'localhost', 8080, '127.0.0.1');
|
|
assert.strictEqual(Object.keys(agent.requests).length, 1);
|
|
assert.strictEqual(
|
|
Object.keys(agent.requests)[0],
|
|
'localhost:8080:127.0.0.1');
|
|
|
|
// `path` is *not* used when naming requests / sockets.
|
|
// Port 8080 is hardcoded since this does not create a network connection
|
|
agent.addRequest(req, {
|
|
host: 'localhost',
|
|
port: 8080,
|
|
localAddress: '127.0.0.1',
|
|
path: '/foo'
|
|
});
|
|
assert.strictEqual(Object.keys(agent.requests).length, 1);
|
|
assert.strictEqual(
|
|
Object.keys(agent.requests)[0],
|
|
'localhost:8080:127.0.0.1');
|