mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
b345118e1e
In `macOS`, fsevents generated immediately before start watching may leak into the event callback. See: https://github.com/nodejs/node/issues/54450 for an explanation. This might be fixed at some point in `libuv` though it may take some time (see: https://github.com/libuv/libuv/issues/3866). This commit comes in anticipation of the soon-to-be-released `libuv@1.49.0` which was making these tests very flaky. PR-URL: https://github.com/nodejs/node/pull/54498 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
49 lines
1.4 KiB
JavaScript
49 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { watch, writeFileSync } = require('node:fs');
|
|
const { join } = require('node:path');
|
|
const tmpdir = require('../common/tmpdir.js');
|
|
const assert = require('assert');
|
|
|
|
if (common.isIBMi)
|
|
common.skip('IBMi does not support `fs.watch()`');
|
|
|
|
// fs-watch on folders have limited capability in AIX.
|
|
// The testcase makes use of folder watching, and causes
|
|
// hang. This behavior is documented. Skip this for AIX.
|
|
|
|
if (common.isAIX)
|
|
common.skip('folder watch capability is limited in AIX.');
|
|
|
|
tmpdir.refresh();
|
|
|
|
const tmpDir = tmpdir.path;
|
|
const filename = join(tmpDir, 'test.file');
|
|
|
|
const keepalive = setTimeout(() => {
|
|
throw new Error('timed out');
|
|
}, common.platformTimeout(30_000));
|
|
|
|
function doWatch() {
|
|
const watcher = watch(tmpDir, { recursive: true }, common.mustCall((eventType, _filename) => {
|
|
clearTimeout(keepalive);
|
|
watcher.close();
|
|
assert.strictEqual(eventType, 'rename');
|
|
assert.strictEqual(join(tmpDir, _filename), filename);
|
|
}));
|
|
|
|
// Do the write with a delay to ensure that the OS is ready to notify us.
|
|
setTimeout(() => {
|
|
writeFileSync(filename, 'foobar2');
|
|
}, common.platformTimeout(200));
|
|
}
|
|
|
|
if (common.isMacOS) {
|
|
// On macOS delay watcher start to avoid leaking previous events.
|
|
// Refs: https://github.com/libuv/libuv/pull/4503
|
|
setTimeout(doWatch, common.platformTimeout(100));
|
|
} else {
|
|
doWatch();
|
|
}
|