mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
39f1b899cd
Fix a file permissions regression when `fs.readFileSync()` is called in append mode on a file that does not already exist introduced by the fast path for utf8 encoding. PR-URL: https://github.com/nodejs/node/pull/52101 Fixes: https://github.com/nodejs/node/issues/52079 Refs: https://github.com/nodejs/node/pull/49691 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
61 lines
2.3 KiB
JavaScript
61 lines
2.3 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const fixtures = require('../common/fixtures');
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
const fn = fixtures.path('elipses.txt');
|
|
tmpdir.refresh();
|
|
|
|
const s = fs.readFileSync(fn, 'utf8');
|
|
for (let i = 0; i < s.length; i++) {
|
|
assert.strictEqual(s[i], '\u2026');
|
|
}
|
|
assert.strictEqual(s.length, 10000);
|
|
|
|
// Test file permissions set for readFileSync() in append mode.
|
|
{
|
|
const expectedMode = 0o666 & ~process.umask();
|
|
|
|
for (const test of [
|
|
{ },
|
|
{ encoding: 'ascii' },
|
|
{ encoding: 'base64' },
|
|
{ encoding: 'hex' },
|
|
{ encoding: 'latin1' },
|
|
{ encoding: 'uTf8' }, // case variation
|
|
{ encoding: 'utf16le' },
|
|
{ encoding: 'utf8' },
|
|
]) {
|
|
const opts = { ...test, flag: 'a+' };
|
|
const file = tmpdir.resolve(`testReadFileSyncAppend${opts.encoding ?? ''}.txt`);
|
|
const variant = `for '${file}'`;
|
|
|
|
const content = fs.readFileSync(file, opts);
|
|
assert.strictEqual(opts.encoding ? content : content.toString(), '', `file contents ${variant}`);
|
|
assert.strictEqual(fs.statSync(file).mode & 0o777, expectedMode, `file permissions ${variant}`);
|
|
}
|
|
}
|