mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
74e0ca3f49
PR-URL: https://github.com/nodejs/node/pull/49125 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
111 lines
3.4 KiB
JavaScript
111 lines
3.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
|
|
// This test ensures that filehandle.write accepts "named parameters" object
|
|
// and doesn't interpret objects as strings
|
|
|
|
const assert = require('assert');
|
|
const fsPromises = require('fs').promises;
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
tmpdir.refresh();
|
|
|
|
const dest = tmpdir.resolve('tmp.txt');
|
|
const buffer = Buffer.from('zyx');
|
|
|
|
async function testInvalid(dest, expectedCode, ...params) {
|
|
if (params.length >= 2) {
|
|
params[1] = common.mustNotMutateObjectDeep(params[1]);
|
|
}
|
|
let fh;
|
|
try {
|
|
fh = await fsPromises.open(dest, 'w+');
|
|
await assert.rejects(
|
|
fh.write(...params),
|
|
{ code: expectedCode });
|
|
} finally {
|
|
await fh?.close();
|
|
}
|
|
}
|
|
|
|
async function testValid(dest, buffer, options) {
|
|
const length = options?.length;
|
|
const offset = options?.offset;
|
|
let fh, writeResult, writeBufCopy, readResult, readBufCopy;
|
|
|
|
try {
|
|
fh = await fsPromises.open(dest, 'w');
|
|
writeResult = await fh.write(buffer, options);
|
|
writeBufCopy = Uint8Array.prototype.slice.call(writeResult.buffer);
|
|
} finally {
|
|
await fh?.close();
|
|
}
|
|
|
|
try {
|
|
fh = await fsPromises.open(dest, 'r');
|
|
readResult = await fh.read(buffer, options);
|
|
readBufCopy = Uint8Array.prototype.slice.call(readResult.buffer);
|
|
} finally {
|
|
await fh?.close();
|
|
}
|
|
|
|
assert.ok(writeResult.bytesWritten >= readResult.bytesRead);
|
|
if (length !== undefined && length !== null) {
|
|
assert.strictEqual(writeResult.bytesWritten, length);
|
|
assert.strictEqual(readResult.bytesRead, length);
|
|
}
|
|
if (offset === undefined || offset === 0) {
|
|
assert.deepStrictEqual(writeBufCopy, readBufCopy);
|
|
}
|
|
assert.deepStrictEqual(writeResult.buffer, readResult.buffer);
|
|
}
|
|
|
|
(async () => {
|
|
// Test if first argument is not wrongly interpreted as ArrayBufferView|string
|
|
for (const badBuffer of [
|
|
undefined, null, true, 42, 42n, Symbol('42'), NaN, [], () => {},
|
|
common.mustNotCall(),
|
|
common.mustNotMutateObjectDeep({}),
|
|
Promise.resolve(new Uint8Array(1)),
|
|
{},
|
|
{ buffer: 'amNotParam' },
|
|
{ string: 'amNotParam' },
|
|
{ buffer: new Uint8Array(1).buffer },
|
|
new Date(),
|
|
new String('notPrimitive'),
|
|
{ toString() { return 'amObject'; } },
|
|
{ [Symbol.toPrimitive]: (hint) => 'amObject' },
|
|
]) {
|
|
await testInvalid(dest, 'ERR_INVALID_ARG_TYPE', common.mustNotMutateObjectDeep(badBuffer), {});
|
|
}
|
|
|
|
// First argument (buffer or string) is mandatory
|
|
await testInvalid(dest, 'ERR_INVALID_ARG_TYPE');
|
|
|
|
// Various invalid options
|
|
await testInvalid(dest, 'ERR_OUT_OF_RANGE', buffer, { length: 5 });
|
|
await testInvalid(dest, 'ERR_OUT_OF_RANGE', buffer, { offset: 5 });
|
|
await testInvalid(dest, 'ERR_OUT_OF_RANGE', buffer, { length: 1, offset: 3 });
|
|
await testInvalid(dest, 'ERR_OUT_OF_RANGE', buffer, { length: -1 });
|
|
await testInvalid(dest, 'ERR_OUT_OF_RANGE', buffer, { offset: -1 });
|
|
await testInvalid(dest, 'ERR_INVALID_ARG_TYPE', buffer, { offset: false });
|
|
await testInvalid(dest, 'ERR_INVALID_ARG_TYPE', buffer, { offset: true });
|
|
|
|
// Test compatibility with filehandle.read counterpart
|
|
for (const options of [
|
|
undefined,
|
|
null,
|
|
{},
|
|
{ length: 1 },
|
|
{ position: 5 },
|
|
{ length: 1, position: 5 },
|
|
{ length: 1, position: -1, offset: 2 },
|
|
{ length: null },
|
|
{ position: null },
|
|
{ offset: 1 },
|
|
]) {
|
|
await testValid(dest, buffer, common.mustNotMutateObjectDeep(options));
|
|
}
|
|
})().then(common.mustCall());
|