mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
b345118e1e
In `macOS`, fsevents generated immediately before start watching may leak into the event callback. See: https://github.com/nodejs/node/issues/54450 for an explanation. This might be fixed at some point in `libuv` though it may take some time (see: https://github.com/libuv/libuv/issues/3866). This commit comes in anticipation of the soon-to-be-released `libuv@1.49.0` which was making these tests very flaky. PR-URL: https://github.com/nodejs/node/pull/54498 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
137 lines
4.0 KiB
JavaScript
137 lines
4.0 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
if (common.isIBMi)
|
|
common.skip('IBMi does not support `fs.watch()`');
|
|
|
|
const { watch } = require('fs/promises');
|
|
const fs = require('fs');
|
|
const assert = require('assert');
|
|
const { join } = require('path');
|
|
const { setTimeout } = require('timers/promises');
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
class WatchTestCase {
|
|
constructor(shouldInclude, dirName, fileName, field) {
|
|
this.dirName = dirName;
|
|
this.fileName = fileName;
|
|
this.field = field;
|
|
this.shouldSkip = !shouldInclude;
|
|
}
|
|
get dirPath() { return tmpdir.resolve(this.dirName); }
|
|
get filePath() { return join(this.dirPath, this.fileName); }
|
|
}
|
|
|
|
const kCases = [
|
|
// Watch on a directory should callback with a filename on supported systems
|
|
new WatchTestCase(
|
|
common.isLinux || common.isMacOS || common.isWindows || common.isAIX,
|
|
'watch1',
|
|
'foo',
|
|
'filePath'
|
|
),
|
|
// Watch on a file should callback with a filename on supported systems
|
|
new WatchTestCase(
|
|
common.isLinux || common.isMacOS || common.isWindows,
|
|
'watch2',
|
|
'bar',
|
|
'dirPath'
|
|
),
|
|
];
|
|
|
|
tmpdir.refresh();
|
|
|
|
for (const testCase of kCases) {
|
|
if (testCase.shouldSkip) continue;
|
|
fs.mkdirSync(testCase.dirPath);
|
|
// Long content so it's actually flushed.
|
|
const content1 = Date.now() + testCase.fileName.toLowerCase().repeat(1e4);
|
|
fs.writeFileSync(testCase.filePath, content1);
|
|
|
|
let interval;
|
|
async function test() {
|
|
if (common.isMacOS) {
|
|
// On macOS delay watcher start to avoid leaking previous events.
|
|
// Refs: https://github.com/libuv/libuv/pull/4503
|
|
await setTimeout(common.platformTimeout(100));
|
|
}
|
|
|
|
const watcher = watch(testCase[testCase.field]);
|
|
for await (const { eventType, filename } of watcher) {
|
|
clearInterval(interval);
|
|
assert.strictEqual(['rename', 'change'].includes(eventType), true);
|
|
assert.strictEqual(filename, testCase.fileName);
|
|
break;
|
|
}
|
|
|
|
// Waiting on it again is a non-op
|
|
// eslint-disable-next-line no-unused-vars
|
|
for await (const p of watcher) {
|
|
assert.fail('should not run');
|
|
}
|
|
}
|
|
|
|
// Long content so it's actually flushed. toUpperCase so there's real change.
|
|
const content2 = Date.now() + testCase.fileName.toUpperCase().repeat(1e4);
|
|
interval = setInterval(() => {
|
|
fs.writeFileSync(testCase.filePath, '');
|
|
fs.writeFileSync(testCase.filePath, content2);
|
|
}, 100);
|
|
|
|
test().then(common.mustCall());
|
|
}
|
|
|
|
assert.rejects(
|
|
async () => {
|
|
// eslint-disable-next-line no-unused-vars, no-empty
|
|
for await (const _ of watch(1)) { }
|
|
},
|
|
{ code: 'ERR_INVALID_ARG_TYPE' }).then(common.mustCall());
|
|
|
|
assert.rejects(
|
|
async () => {
|
|
// eslint-disable-next-line no-unused-vars, no-empty
|
|
for await (const _ of watch(__filename, 1)) { }
|
|
},
|
|
{ code: 'ERR_INVALID_ARG_TYPE' }).then(common.mustCall());
|
|
|
|
assert.rejects(
|
|
async () => {
|
|
// eslint-disable-next-line no-unused-vars, no-empty
|
|
for await (const _ of watch('', { persistent: 1 })) { }
|
|
},
|
|
{ code: 'ERR_INVALID_ARG_TYPE' }).then(common.mustCall());
|
|
|
|
assert.rejects(
|
|
async () => {
|
|
// eslint-disable-next-line no-unused-vars, no-empty
|
|
for await (const _ of watch('', { recursive: 1 })) { }
|
|
},
|
|
{ code: 'ERR_INVALID_ARG_TYPE' }).then(common.mustCall());
|
|
|
|
assert.rejects(
|
|
async () => {
|
|
// eslint-disable-next-line no-unused-vars, no-empty
|
|
for await (const _ of watch('', { encoding: 1 })) { }
|
|
},
|
|
{ code: 'ERR_INVALID_ARG_VALUE' }).then(common.mustCall());
|
|
|
|
assert.rejects(
|
|
async () => {
|
|
// eslint-disable-next-line no-unused-vars, no-empty
|
|
for await (const _ of watch('', { signal: 1 })) { }
|
|
},
|
|
{ code: 'ERR_INVALID_ARG_TYPE' }).then(common.mustCall());
|
|
|
|
(async () => {
|
|
const ac = new AbortController();
|
|
const { signal } = ac;
|
|
setImmediate(() => ac.abort());
|
|
try {
|
|
// eslint-disable-next-line no-unused-vars, no-empty
|
|
for await (const _ of watch(__filename, { signal })) { }
|
|
} catch (err) {
|
|
assert.strictEqual(err.name, 'AbortError');
|
|
}
|
|
})().then(common.mustCall());
|