mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 21:19:50 +01:00
53ede878a5
Fixes: https://github.com/nodejs/node/issues/50993 Refs: https://github.com/nodejs/node/issues/51451 test: remove unnecessary comment src: conform to style guidelines src: change flag to `--env-file-optional` test: revert automatic linter changes doc: fix typos src: change flag to `--env-file-if-exists` src: refactor `env_file_data` and `GetEnvFileDataFromArgs` test: clean up tests src: print error when file not found test: remove unnecessary extras PR-URL: https://github.com/nodejs/node/pull/53060 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
152 lines
5.1 KiB
JavaScript
152 lines
5.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('node:assert');
|
|
const path = require('node:path');
|
|
const { describe, it } = require('node:test');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const validEnvFilePath = '../fixtures/dotenv/valid.env';
|
|
const nodeOptionsEnvFilePath = '../fixtures/dotenv/node-options.env';
|
|
|
|
describe('.env supports edge cases', () => {
|
|
it('supports multiple declarations, including optional ones', async () => {
|
|
const code = `
|
|
const assert = require('assert');
|
|
assert.strictEqual(process.env.BASIC, 'basic');
|
|
assert.strictEqual(process.env.NODE_NO_WARNINGS, '1');
|
|
`.trim();
|
|
const children = await Promise.all(Array.from({ length: 4 }, (_, i) =>
|
|
common.spawnPromisified(
|
|
process.execPath,
|
|
[
|
|
// Bitwise AND to create all 4 possible combinations:
|
|
// i & 0b01 is truthy when i has value 0bx1 (i.e. 0b01 (1) and 0b11 (3)), falsy otherwise.
|
|
// i & 0b10 is truthy when i has value 0b1x (i.e. 0b10 (2) and 0b11 (3)), falsy otherwise.
|
|
`${i & 0b01 ? '--env-file' : '--env-file-if-exists'}=${nodeOptionsEnvFilePath}`,
|
|
`${i & 0b10 ? '--env-file' : '--env-file-if-exists'}=${validEnvFilePath}`,
|
|
'--eval', code,
|
|
],
|
|
{ cwd: __dirname },
|
|
)));
|
|
assert.deepStrictEqual(children, Array.from({ length: 4 }, () => ({
|
|
code: 0,
|
|
signal: null,
|
|
stdout: '',
|
|
stderr: '',
|
|
})));
|
|
});
|
|
|
|
it('supports absolute paths', async () => {
|
|
const code = `
|
|
require('assert').strictEqual(process.env.BASIC, 'basic');
|
|
`.trim();
|
|
const child = await common.spawnPromisified(
|
|
process.execPath,
|
|
[ `--env-file=${path.resolve(__dirname, validEnvFilePath)}`, '--eval', code ],
|
|
);
|
|
assert.strictEqual(child.stderr, '');
|
|
assert.strictEqual(child.code, 0);
|
|
});
|
|
|
|
it('supports a space instead of \'=\' for the flag ', async () => {
|
|
const code = `
|
|
require('assert').strictEqual(process.env.BASIC, 'basic');
|
|
`.trim();
|
|
const child = await common.spawnPromisified(
|
|
process.execPath,
|
|
[ '--env-file', validEnvFilePath, '--eval', code ],
|
|
{ cwd: __dirname },
|
|
);
|
|
assert.strictEqual(child.stderr, '');
|
|
assert.strictEqual(child.code, 0);
|
|
});
|
|
|
|
it('should handle non-existent .env file', async () => {
|
|
const code = `
|
|
require('assert').strictEqual(1, 1)
|
|
`.trim();
|
|
const child = await common.spawnPromisified(
|
|
process.execPath,
|
|
[ '--env-file=.env', '--eval', code ],
|
|
{ cwd: __dirname },
|
|
);
|
|
assert.notStrictEqual(child.stderr, '');
|
|
assert.strictEqual(child.code, 9);
|
|
});
|
|
|
|
it('should handle non-existent optional .env file', async () => {
|
|
const code = `
|
|
require('assert').strictEqual(1,1);
|
|
`.trim();
|
|
const child = await common.spawnPromisified(
|
|
process.execPath,
|
|
['--env-file-if-exists=.env', '--eval', code],
|
|
{ cwd: __dirname },
|
|
);
|
|
assert.notStrictEqual(child.stderr, '');
|
|
assert.strictEqual(child.code, 0);
|
|
});
|
|
|
|
it('should not override existing environment variables but introduce new vars', async () => {
|
|
const code = `
|
|
require('assert').strictEqual(process.env.BASIC, 'existing');
|
|
require('assert').strictEqual(process.env.AFTER_LINE, 'after_line');
|
|
`.trim();
|
|
const child = await common.spawnPromisified(
|
|
process.execPath,
|
|
[ `--env-file=${validEnvFilePath}`, '--eval', code ],
|
|
{ cwd: __dirname, env: { ...process.env, BASIC: 'existing' } },
|
|
);
|
|
assert.strictEqual(child.stderr, '');
|
|
assert.strictEqual(child.code, 0);
|
|
});
|
|
|
|
it('should handle multiline quoted values', async () => {
|
|
// Ref: https://github.com/nodejs/node/issues/52248
|
|
const code = `
|
|
process.loadEnvFile('./multiline.env');
|
|
require('node:assert').ok(process.env.JWT_PUBLIC_KEY);
|
|
`.trim();
|
|
const child = await common.spawnPromisified(
|
|
process.execPath,
|
|
[ '--eval', code ],
|
|
{ cwd: fixtures.path('dotenv') },
|
|
);
|
|
assert.strictEqual(child.stdout, '');
|
|
assert.strictEqual(child.stderr, '');
|
|
assert.strictEqual(child.code, 0);
|
|
});
|
|
|
|
it('should handle empty value without a newline at the EOF', async () => {
|
|
// Ref: https://github.com/nodejs/node/issues/52466
|
|
const code = `
|
|
process.loadEnvFile('./eof-without-value.env');
|
|
require('assert').strictEqual(process.env.BASIC, 'value');
|
|
require('assert').strictEqual(process.env.EMPTY, '');
|
|
`.trim();
|
|
const child = await common.spawnPromisified(
|
|
process.execPath,
|
|
[ '--eval', code ],
|
|
{ cwd: fixtures.path('dotenv') },
|
|
);
|
|
assert.strictEqual(child.stdout, '');
|
|
assert.strictEqual(child.stderr, '');
|
|
assert.strictEqual(child.code, 0);
|
|
});
|
|
|
|
it('should handle when --env-file is passed along with --', async () => {
|
|
const child = await common.spawnPromisified(
|
|
process.execPath,
|
|
[
|
|
'--eval', `require('assert').strictEqual(process.env.BASIC, undefined);`,
|
|
'--', '--env-file', validEnvFilePath,
|
|
],
|
|
{ cwd: __dirname },
|
|
);
|
|
assert.strictEqual(child.stdout, '');
|
|
assert.strictEqual(child.stderr, '');
|
|
assert.strictEqual(child.code, 0);
|
|
});
|
|
});
|